From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, vkoul@kernel.org
Subject: Re: [PATCH v2 8/9] ASoC: qdsp6-dai: add gapless support
Date: Wed, 22 Jul 2020 10:31:54 -0500 [thread overview]
Message-ID: <d572887f-8550-89dd-02f0-986ef081bf40@linux.intel.com> (raw)
In-Reply-To: <eadfd218-be93-0dc9-df94-a64ea494c6bf@linaro.org>
>>> @@ -917,6 +1018,14 @@ static int q6asm_dai_compr_trigger(struct
>>> snd_soc_component *component,
>>> ret = q6asm_cmd_nowait(prtd->audio_client, prtd->stream_id,
>>> CMD_PAUSE);
>>> break;
>>> + case SND_COMPR_TRIGGER_NEXT_TRACK:
>>> + prtd->next_track = true;
>>> + prtd->next_track_stream_id = (prtd->stream_id == 1 ? 2 : 1);
>>
>> it's rather odd, the initialization above uses next_track_stream_id = 0?
>
> Vaild stream ids start from 1, So we are toggling this between 1 and 2.
> So when we set next_track_stream_id to 0, that means we have opened the
> new next stream id and is set to prtd->stream_id. This logic is to
> ensure that we are not going to open next stream id twice!
ok, adding a comment would be good to show this was intentional and not
a mistake.
next prev parent reply other threads:[~2020-07-22 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 16:52 [PATCH v2 0/9] ASoC: qdsp6: add gapless compressed audio support Srinivas Kandagatla
2020-07-21 16:52 ` [PATCH v2 1/9] ASoC: q6asm: rename misleading session id variable Srinivas Kandagatla
2020-07-21 16:52 ` [PATCH v2 2/9] ASoC: q6asm: make commands specific to streams Srinivas Kandagatla
2020-07-21 19:31 ` Pierre-Louis Bossart
2020-07-22 8:59 ` Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 3/9] ASoC: q6asm: use flags directly from q6asm-dai Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 4/9] ASoC: q6asm: add length to write command token Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 5/9] ASoC: q6asm: add support to remove intial and trailing silence Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 6/9] ASoC: q6asm: add support to gapless flag in q6asm open Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 7/9] ASoC: q6asm-dai: add next track metadata support Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 8/9] ASoC: qdsp6-dai: add gapless support Srinivas Kandagatla
2020-07-21 19:53 ` Pierre-Louis Bossart
2020-07-22 9:00 ` Srinivas Kandagatla
2020-07-22 15:31 ` Pierre-Louis Bossart [this message]
2020-07-21 16:53 ` [PATCH v2 9/9] ASoC: q6asm-dai: add support to copy callback Srinivas Kandagatla
2020-07-21 19:54 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d572887f-8550-89dd-02f0-986ef081bf40@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).