From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E39C433E6 for ; Tue, 23 Feb 2021 16:06:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B5CE64E61 for ; Tue, 23 Feb 2021 16:06:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233528AbhBWQG0 (ORCPT ); Tue, 23 Feb 2021 11:06:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233355AbhBWQGT (ORCPT ); Tue, 23 Feb 2021 11:06:19 -0500 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B341C061786 for ; Tue, 23 Feb 2021 08:05:38 -0800 (PST) Received: by mail-io1-xd2f.google.com with SMTP id 74so2144072iob.0 for ; Tue, 23 Feb 2021 08:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qp39F608telK2g5bl2vnH3DV36nCXGkIBvfuxBxCEpY=; b=Fc5JL2D74YRtPChhudq6t+o1f9MaKKi0XlmCIBRl9Nb9+83049FLi9RX5ILEingifB iDeeO2qENKsoDyvLmOpm/9LEKPg4VlXj69JSymwOTlw2m07mmiFkYNvWRosyNfxhNNi1 VBiaQp9WMVqPK/Om3Ue+HMFISRBNBYltEArzs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qp39F608telK2g5bl2vnH3DV36nCXGkIBvfuxBxCEpY=; b=XpkV1NY8bzGGiEKNuTQ2UrSga5PqDRofOxH7H/1M8bVObR/LagLH84I9YulQiDMW2f j7F8qOW8cg2UXrSXn82TR5A+R46ftGRuFgnRBEkdkpGZbvVVadeoJEo5QRSpmkh8dESq QT2RFqwbIKCiY3XWLh/I6a2vWZZEnehON1meRIJiB1/AfHzHuNi8GThsM2GnNmAU2Vd4 SPYF9CQNHOWUJOQq9a8CVfLrPtZk10t5PeKEKnkyJnqHgSqfkqdTkiq7IaDbqBtlpTN/ kPAd2hbvQBDgdheMaF7DmWV+8Qf5v7xGX2XG4mVYIWrTQpg/PHTAhfS1UvKTiOb220GQ F4gg== X-Gm-Message-State: AOAM530gpRr4kRpmzbheoFCsgmGscJnvxCr2VhytOd9TB3NqfsDp4Qa9 zqi1tuku+FcjMPs95YU8tAJEoeX577kxGA== X-Google-Smtp-Source: ABdhPJyCtLBbrhnuCswxsSSKtEbIVZs8PMT6HfXbak31SxSBn5MDXpSC4e9rcFyuUuZVPvBGFxcGiQ== X-Received: by 2002:a5d:8ac5:: with SMTP id e5mr19743306iot.33.1614096337331; Tue, 23 Feb 2021 08:05:37 -0800 (PST) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id s14sm3978152ilj.83.2021.02.23.08.05.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Feb 2021 08:05:36 -0800 (PST) Subject: Re: [PATCH] drivers: ipa: Add missing IRQF_ONESHOT To: Yang Li , elder@kernel.org Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1614071362-123210-1-git-send-email-yang.lee@linux.alibaba.com> From: Alex Elder Message-ID: Date: Tue, 23 Feb 2021 10:05:35 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1614071362-123210-1-git-send-email-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/23/21 3:09 AM, Yang Li wrote: > fixed the following coccicheck: > ./drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT > > Make sure threaded IRQs without a primary handler are always request > with IRQF_ONESHOT SMP2P interrupts are handled as nested interrupts. The hard handler for a registered SMP2P interrupt is never called, and is in fact ignored (it should really be NULL when registering). The "main" SMP2P interrupt handler is a ONESHOT threaded interrupt handler, and all registered SMP2P interrupts are handled within (called by) that main handler thread function. It is not *necessary* to provide the IRQF_ONESHOT flag when registering an SMP2P interrupt handler. I don't think it does real harm to add it, but unless I'm mistaken, the interrupt handling is actually simpler if ONESHOT is *not* set in this case. I could be convinced otherwise, but until I would rather not accept this patch. -Alex > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/net/ipa/ipa_smp2p.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c > index a5f7a79..1149ed8 100644 > --- a/drivers/net/ipa/ipa_smp2p.c > +++ b/drivers/net/ipa/ipa_smp2p.c > @@ -183,7 +183,7 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name, > } > irq = ret; > > - ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p); > + ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT, name, smp2p); > if (ret) { > dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name); > return ret; >