* [PATCH] nitro_enclaves: Remove redundant 'flush_workqueue()' calls
@ 2021-11-12 17:09 Christophe JAILLET
2021-11-13 12:44 ` Paraschiv, Andra-Irina
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-11-12 17:09 UTC (permalink / raw)
To: andraprs, lexnv, alcioa; +Cc: linux-kernel, kernel-janitors, Christophe JAILLET
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/virt/nitro_enclaves/ne_pci_dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/virt/nitro_enclaves/ne_pci_dev.c b/drivers/virt/nitro_enclaves/ne_pci_dev.c
index 40b49ec8e30b..6b81e8f3a5dc 100644
--- a/drivers/virt/nitro_enclaves/ne_pci_dev.c
+++ b/drivers/virt/nitro_enclaves/ne_pci_dev.c
@@ -376,7 +376,6 @@ static void ne_teardown_msix(struct pci_dev *pdev)
free_irq(pci_irq_vector(pdev, NE_VEC_EVENT), ne_pci_dev);
flush_work(&ne_pci_dev->notify_work);
- flush_workqueue(ne_pci_dev->event_wq);
destroy_workqueue(ne_pci_dev->event_wq);
free_irq(pci_irq_vector(pdev, NE_VEC_REPLY), ne_pci_dev);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nitro_enclaves: Remove redundant 'flush_workqueue()' calls
2021-11-12 17:09 [PATCH] nitro_enclaves: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
@ 2021-11-13 12:44 ` Paraschiv, Andra-Irina
0 siblings, 0 replies; 2+ messages in thread
From: Paraschiv, Andra-Irina @ 2021-11-13 12:44 UTC (permalink / raw)
To: Christophe JAILLET
Cc: linux-kernel, kernel-janitors, lexnv, alcioa, Greg KH,
Kamal Mostafa, Paolo Bonzini, Stefano Garzarella,
Stefan Hajnoczi, Vitaly Kuznetsov, ne-devel-upstream, kvm
On 12/11/2021 19:09, Christophe JAILLET wrote:
>
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/virt/nitro_enclaves/ne_pci_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/virt/nitro_enclaves/ne_pci_dev.c b/drivers/virt/nitro_enclaves/ne_pci_dev.c
> index 40b49ec8e30b..6b81e8f3a5dc 100644
> --- a/drivers/virt/nitro_enclaves/ne_pci_dev.c
> +++ b/drivers/virt/nitro_enclaves/ne_pci_dev.c
> @@ -376,7 +376,6 @@ static void ne_teardown_msix(struct pci_dev *pdev)
> free_irq(pci_irq_vector(pdev, NE_VEC_EVENT), ne_pci_dev);
>
> flush_work(&ne_pci_dev->notify_work);
> - flush_workqueue(ne_pci_dev->event_wq);
> destroy_workqueue(ne_pci_dev->event_wq);
>
> free_irq(pci_irq_vector(pdev, NE_VEC_REPLY), ne_pci_dev);
> --
> 2.30.2
>
Thank you for the patch.
Reviewed-by: Andra Paraschiv <andraprs@amazon.com>
Thanks,
Andra
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-13 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 17:09 [PATCH] nitro_enclaves: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-11-13 12:44 ` Paraschiv, Andra-Irina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).