From: Paul Kocialkowski <contact@paulk.fr>
To: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Randy Li <ayaka@soulik.info>,
Ezequiel Garcia <ezequiel@collabora.com>,
Tomasz Figa <tfiga@chromium.org>,
Alexandre Courbot <acourbot@chromium.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver
Date: Fri, 07 Sep 2018 17:04:29 +0200 [thread overview]
Message-ID: <d581b9cc8153d063360d8cde290329f5c1786ae9.camel@paulk.fr> (raw)
In-Reply-To: <890469f8-434f-4ca1-ec95-20542610fd78@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 3540 bytes --]
Hi,
Le jeudi 06 septembre 2018 à 09:22 +0200, Hans Verkuil a écrit :
> On 09/06/2018 09:01 AM, Hans Verkuil wrote:
> > On 09/05/2018 06:29 PM, Paul Kocialkowski wrote:
> > > Hi and thanks for the review!
> > >
> > > Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit :
> > > > On 08/28/2018 09:34 AM, Paul Kocialkowski wrote:
> > > > > +static int cedrus_queue_setup(struct vb2_queue *vq, unsigned int *nbufs,
> > > > > + unsigned int *nplanes, unsigned int sizes[],
> > > > > + struct device *alloc_devs[])
> > > > > +{
> > > > > + struct cedrus_ctx *ctx = vb2_get_drv_priv(vq);
> > > > > + struct cedrus_dev *dev = ctx->dev;
> > > > > + struct v4l2_pix_format_mplane *mplane_fmt;
> > > > > + struct cedrus_format *fmt;
> > > > > + unsigned int i;
> > > > > +
> > > > > + switch (vq->type) {
> > > > > + case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
> > > > > + mplane_fmt = &ctx->src_fmt;
> > > > > + fmt = cedrus_find_format(mplane_fmt->pixelformat,
> > > > > + CEDRUS_DECODE_SRC,
> > > > > + dev->capabilities);
> > > > > + break;
> > > > > +
> > > > > + case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
> > > > > + mplane_fmt = &ctx->dst_fmt;
> > > > > + fmt = cedrus_find_format(mplane_fmt->pixelformat,
> > > > > + CEDRUS_DECODE_DST,
> > > > > + dev->capabilities);
> > > > > + break;
> > > > > +
> > > > > + default:
> > > > > + return -EINVAL;
> > > > > + }
> > > > > +
> > > > > + if (!fmt)
> > > > > + return -EINVAL;
> > > > > +
> > > > > + if (fmt->num_buffers == 1) {
> > > > > + sizes[0] = 0;
> > > > > +
> > > > > + for (i = 0; i < fmt->num_planes; i++)
> > > > > + sizes[0] += mplane_fmt->plane_fmt[i].sizeimage;
> > > > > + } else if (fmt->num_buffers == fmt->num_planes) {
> > > > > + for (i = 0; i < fmt->num_planes; i++)
> > > > > + sizes[i] = mplane_fmt->plane_fmt[i].sizeimage;
> > > > > + } else {
> > > > > + return -EINVAL;
> > > > > + }
> > > > > +
> > > > > + *nplanes = fmt->num_buffers;
> > > >
> > > > This code does not take VIDIOC_CREATE_BUFFERS into account.
> > > >
> > > > If it is called from that ioctl, then *nplanes is non-zero and you need
> > > > to check if *nplanes equals fmt->num_buffers and that sizes[n] is >=
> > > > the required size of the format. If so, then return 0, otherwise return
> > > > -EINVAL.
> > >
> > > Thanks for spotting this, I'll fix it as you suggested in the next
> > > revision.
> > >
> > > > Doesn't v4l2-compliance fail on that? Or is that test skipped because this
> > > > is a decoder for which streaming is not supported (yet)?
> > >
> > > Apparently, v4l2-compliance doesn't fail since I'm getting:
> > > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> >
> > It is tested, but only with the -s option. I'll see if I can improve the
> > tests.
>
> I've improved the tests. v4l2-compliance should now fail when run (without the
> -s option) against this driver. Can you check that that is indeed the case?
I think this wasn't being tested with v8 of the driver as no default
format was provided (for the G_FMT test), which probably led to MMAP
not being picked up in valid_memorytype. Thus the subsequent
CREATE_BUFS test was reported as not failing, but it really didn't test
much of anything.
Cheers,
Paul
--
Developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-07 15:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 7:34 [PATCH v8 0/8] Cedrus driver for the Allwinner Video Engine, using media requests Paul Kocialkowski
2018-08-28 7:34 ` [PATCH v8 1/8] media: v4l: Add definitions for MPEG2 slice format and metadata Paul Kocialkowski
2018-09-03 8:32 ` Hans Verkuil
2018-09-05 15:42 ` Paul Kocialkowski
2018-08-28 7:34 ` [PATCH v8 2/8] media: v4l: Add definition for the Sunxi tiled NV12 format Paul Kocialkowski
2018-08-28 7:34 ` [PATCH v8 3/8] dt-bindings: media: Document bindings for the Cedrus VPU driver Paul Kocialkowski
2018-08-28 14:44 ` Maxime Ripard
2018-08-28 14:47 ` [linux-sunxi] " Corentin Labbe
2018-09-05 15:43 ` Paul Kocialkowski
2018-08-28 7:34 ` [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver Paul Kocialkowski
2018-08-28 14:56 ` Maxime Ripard
2018-08-29 1:08 ` Ezequiel Garcia
2018-09-05 15:49 ` Paul Kocialkowski
2018-09-03 9:11 ` Hans Verkuil
2018-09-05 16:29 ` Paul Kocialkowski
2018-09-06 7:01 ` Hans Verkuil
2018-09-06 7:22 ` Hans Verkuil
2018-09-07 15:04 ` Paul Kocialkowski [this message]
2018-09-06 7:25 ` Tomasz Figa
2018-09-06 7:39 ` Hans Verkuil
2018-09-07 8:05 ` Tomasz Figa
2018-08-28 7:34 ` [PATCH v8 5/8] ARM: dts: sun5i: Add Video Engine and reserved memory nodes Paul Kocialkowski
2018-08-28 14:55 ` Maxime Ripard
2018-08-28 7:34 ` [PATCH v8 6/8] ARM: dts: sun7i-a20: " Paul Kocialkowski
2018-08-28 14:55 ` Maxime Ripard
2018-08-28 7:34 ` [PATCH v8 7/8] ARM: dts: sun8i-a33: " Paul Kocialkowski
2018-08-28 14:55 ` Maxime Ripard
2018-08-28 7:34 ` [PATCH v8 8/8] ARM: dts: sun8i-h3: " Paul Kocialkowski
2018-08-28 14:55 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d581b9cc8153d063360d8cde290329f5c1786ae9.camel@paulk.fr \
--to=contact@paulk.fr \
--cc=acourbot@chromium.org \
--cc=ayaka@soulik.info \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).