linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ravi V Shankar <ravi.v.shankar@intel.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
	kvm@vger.kernel.org
Subject: Re: [PATCH v4 07/17] x86/split_lock: Enumerate #AC for split lock by MSR IA32_CORE_CAPABILITY
Date: Mon, 4 Mar 2019 11:19:31 -0800	[thread overview]
Message-ID: <d582d469-40aa-287e-4368-723bf3ff4251@intel.com> (raw)
In-Reply-To: <20190304185922.GA231946@romley-ivt3.sc.intel.com>

On 3/4/19 10:59 AM, Fenghua Yu wrote:
>> But, it goes unmentioned why you do the boot-cpu-only restriction here.
>>  It doesn't match the behavior of the two functions called before
>> init_core_capability():
>>
>>         init_scattered_cpuid_features(c);
>>         init_speculation_control(c);
>>
>> So why is this new function special?
> The function sets the split_lock_detect feature which needs to be
> applied before BSP calls apply_enforced_caps() in get_cpu_cap(). 

Why does it need to be applied that way?

> And I want to enable split lock detection in earlier phase to detect
> split lock earlier.

Why do you want to do this?  Why is this *required* as part of this
implementation?

... and how is this different than the other features that are processed
for cpus other than the boot CPU?

  reply	other threads:[~2019-03-04 19:19 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02  2:44 [PATCH v4 00/17] x86/split_lock: Enable #AC exception for split locked accesses Fenghua Yu
2019-03-02  2:44 ` [PATCH v4 01/17] x86/common: Align cpu_caps_cleared and cpu_caps_set to unsigned long Fenghua Yu
2019-03-04  8:33   ` Paolo Bonzini
2019-03-04 10:17     ` Peter Zijlstra
2019-03-04 10:48       ` Paolo Bonzini
2019-03-04 12:44         ` Peter Zijlstra
2019-03-04 13:13           ` Paolo Bonzini
2019-03-02  2:44 ` [PATCH v4 02/17] drivers/net/b44: Align pwol_mask to unsigned long for better performance Fenghua Yu
2019-03-04 10:00   ` Peter Zijlstra
2019-03-04 14:45     ` Fenghua Yu
2019-03-04 15:27       ` Peter Zijlstra
2019-03-02  2:44 ` [PATCH v4 03/17] wlcore: Align reg_ch_conf_pending and tmp_ch_bitmap " Fenghua Yu
2019-03-04 10:11   ` Peter Zijlstra
2019-03-04 10:46     ` Paolo Bonzini
2019-03-04 12:41       ` Peter Zijlstra
2019-03-04 13:09         ` Paolo Bonzini
2019-03-04 13:30           ` Peter Zijlstra
2019-03-04 14:40       ` Fenghua Yu
2019-03-04 15:54         ` Paolo Bonzini
2019-03-02  2:44 ` [PATCH v4 04/17] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access Fenghua Yu
2019-03-04 18:52   ` Dave Hansen
2019-03-04 19:15     ` Fenghua Yu
2019-03-04 19:29       ` Dave Hansen
2019-03-04 20:08       ` Peter Zijlstra
2019-03-04 20:12     ` Peter Zijlstra
2019-03-02  2:44 ` [PATCH v4 05/17] x86/cpufeatures: Enumerate IA32_CORE_CAPABILITIES MSR Fenghua Yu
2019-03-04 18:53   ` Dave Hansen
2019-03-04 18:55     ` Yu, Fenghua
2019-03-04 19:01       ` Dave Hansen
2019-03-02  2:45 ` [PATCH v4 06/17] x86/msr-index: Define IA32_CORE_CAPABILITY MSR and #AC exception for split lock bit Fenghua Yu
2019-03-02  2:45 ` [PATCH v4 07/17] x86/split_lock: Enumerate #AC for split lock by MSR IA32_CORE_CAPABILITY Fenghua Yu
2019-03-04 18:58   ` Dave Hansen
2019-03-04 18:59     ` Fenghua Yu
2019-03-04 19:19       ` Dave Hansen [this message]
2019-03-02  2:45 ` [PATCH v4 08/17] x86/clearcpuid: Support multiple clearcpuid options Fenghua Yu
2019-03-02  2:45 ` [PATCH v4 09/17] x86/clearcpuid: Support feature flag string in kernel option clearcpuid Fenghua Yu
2019-03-02  2:45 ` [PATCH v4 10/17] x86/clearcpuid: Apply cleared feature bits that are forced set before Fenghua Yu
2019-03-02  2:45 ` [PATCH v4 11/17] x86/clearcpuid: Clear CPUID bit in CPUID faulting Fenghua Yu
2019-03-04 22:04   ` kbuild test robot
2019-03-05  7:27   ` kbuild test robot
2019-03-02  2:45 ` [PATCH v4 12/17] Change document for kernel option clearcpuid Fenghua Yu
2019-03-02  2:45 ` [PATCH v4 13/17] x86/split_lock: Handle #AC exception for split lock Fenghua Yu
2019-03-02  2:45 ` [PATCH v4 14/17] x86/split_lock: Add a sysfs interface to allow user to enable or disable split lock detection on all CPUs during run time Fenghua Yu
2019-03-02  2:45 ` [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID Fenghua Yu
2019-03-04  8:38   ` Paolo Bonzini
2019-03-04 10:47     ` Xiaoyao Li
2019-03-04 10:49       ` Paolo Bonzini
2019-03-04 11:10         ` Xiaoyao Li
2019-03-04 11:14           ` Paolo Bonzini
2019-03-04 11:21             ` Xiaoyao Li
2019-03-05  7:03             ` Xiaoyao Li
2019-03-02  2:45 ` [PATCH v4 16/17] kvm: x86: Add support IA32_CORE_CAPABILITY MSR Fenghua Yu
2019-03-04  8:42   ` Paolo Bonzini
2019-03-04 12:32     ` Xiaoyao Li
2019-03-08  6:10     ` Xiaoyao Li
2019-03-08  7:54       ` Paolo Bonzini
2019-03-08  8:03         ` Xiaoyao Li
2019-03-02  2:45 ` [PATCH v4 17/17] kvm: vmx: Emulate TEST_CTL MSR Fenghua Yu
2019-03-09  2:31   ` Xiaoyao Li
2019-03-11 13:31     ` Paolo Bonzini
2019-03-11 15:10       ` Xiaoyao Li
2019-03-11 15:21         ` Paolo Bonzini
2019-03-11 16:58           ` Xiaoyao Li
2019-03-04 21:55 ` [PATCH v4 00/17] x86/split_lock: Enable #AC exception for split locked accesses Konrad Rzeszutek Wilk
2019-03-05  0:06   ` Fenghua Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d582d469-40aa-287e-4368-723bf3ff4251@intel.com \
    --to=dave.hansen@intel.com \
    --cc=ashok.raj@intel.com \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).