From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755099AbcFQLgy (ORCPT ); Fri, 17 Jun 2016 07:36:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:54323 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcFQLgx (ORCPT ); Fri, 17 Jun 2016 07:36:53 -0400 Subject: Re: [PATCH 26/27] mm: vmstat: Replace __count_zone_vm_events with a zone id equivalent To: Mel Gorman , Andrew Morton , Linux-MM References: <1465495483-11855-1-git-send-email-mgorman@techsingularity.net> <1465495483-11855-27-git-send-email-mgorman@techsingularity.net> Cc: Rik van Riel , Johannes Weiner , LKML From: Vlastimil Babka Message-ID: Date: Fri, 17 Jun 2016 13:36:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1465495483-11855-27-git-send-email-mgorman@techsingularity.net> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2016 08:04 PM, Mel Gorman wrote: > This is partially a preparation patch for more vmstat work but it also > has the slight advantage that __count_zid_vm_events is cheaper to > calculate than __count_zone_vm_events(). > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > include/linux/vmstat.h | 5 ++--- > mm/page_alloc.c | 2 +- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index 533948c93550..2feab717704d 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -107,9 +107,8 @@ static inline void vm_events_fold_cpu(int cpu) > #define count_vm_vmacache_event(x) do {} while (0) > #endif > > -#define __count_zone_vm_events(item, zone, delta) \ > - __count_vm_events(item##_NORMAL - ZONE_NORMAL + \ > - zone_idx(zone), delta) > +#define __count_zid_vm_events(item, zid, delta) \ > + __count_vm_events(item##_NORMAL - ZONE_NORMAL + zid, delta) > > /* > * Zone and node-based page accounting with per cpu differentials. > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7c6c18a314a1..028d088633c4 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2621,7 +2621,7 @@ struct page *buffered_rmqueue(struct zone *preferred_zone, > get_pcppage_migratetype(page)); > } > > - __count_zone_vm_events(PGALLOC, zone, 1 << order); > + __count_zid_vm_events(PGALLOC, page_zonenum(page), 1 << order); > zone_statistics(preferred_zone, zone, gfp_flags); > local_irq_restore(flags); > >