From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756061AbcGZJTP (ORCPT ); Tue, 26 Jul 2016 05:19:15 -0400 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:43371 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752923AbcGZJTM (ORCPT ); Tue, 26 Jul 2016 05:19:12 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: dt2811: add parentheses to fix logic on s->subdev_flags To: Colin King , H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org References: <1469485525-17632-1-git-send-email-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: Date: Tue, 26 Jul 2016 10:19:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1469485525-17632-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/07/16 23:25, Colin King wrote: > From: Colin Ian King > > We need to add parentheses around ternary operations because currently > the expression SDF_READABLE | (it->options[2] == 1) always evaluates to > true, meaning s->subdev_flags is always assigned SDF_DIFF. Putting the > parentheses around the ternarary operations results in the intended > expression of SDF_REABLE logically or'd with one of SDF_DIFF, > SDF_COMMON or SDF_GROUND. > > Signed-off-by: Colin Ian King > --- > drivers/staging/comedi/drivers/dt2811.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c > index 904f6377..8bbd938 100644 > --- a/drivers/staging/comedi/drivers/dt2811.c > +++ b/drivers/staging/comedi/drivers/dt2811.c > @@ -588,8 +588,8 @@ static int dt2811_attach(struct comedi_device *dev, struct comedi_devconfig *it) > s = &dev->subdevices[0]; > s->type = COMEDI_SUBD_AI; > s->subdev_flags = SDF_READABLE | > - (it->options[2] == 1) ? SDF_DIFF : > - (it->options[2] == 2) ? SDF_COMMON : SDF_GROUND; > + ((it->options[2] == 1) ? SDF_DIFF : > + (it->options[2] == 2) ? SDF_COMMON : SDF_GROUND); > s->n_chan = (it->options[2] == 1) ? 8 : 16; > s->maxdata = 0x0fff; > s->range_table = board->is_pgh ? &dt2811_pgh_ai_ranges > Thanks for catching that. Fixes: 7c9574090d30 ("staging: comedi: dt2811: simplify A/D reference configuration" Cc: # 4.7+ Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-