From: Sibi S <sibis@codeaurora.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: p.zabel@pengutronix.de, robh+dt@kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, georgi.djakov@linaro.org, jassisinghbrar@gmail.com, ohad@wizery.com, mark.rutland@arm.com, kyan@codeaurora.org, sricharan@codeaurora.org, akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org, tsoni@codeaurora.org Subject: Re: [PATCH v3 1/7] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs Date: Wed, 21 Mar 2018 11:59:30 +0530 Message-ID: <d5a7f0c0-5daa-d2ac-a383-9456e9e38e4f@codeaurora.org> (raw) In-Reply-To: <20180318224459.GC5626@tuxbook-pro> Hi Bjorn, Thanks for the review. On 03/19/2018 04:14 AM, Bjorn Andersson wrote: > On Wed 14 Mar 02:21 PDT 2018, Sibi S wrote: >> +- reg: >> + Usage: required >> + Value type: <prop-encoded-array> >> + Definition: must specify the base address and size of the register >> + space. >> + >> + > > Double empty lines. > will remove them >> +- #reset-cells: >> + Usage: required >> + Value type: <uint> >> + Definition: must be 1; cell entry represents the reset index. >> + >> +example: > > Please capitalize the initial char. > sure >> + >> +aoss_reset: qcom,reset-controller@b2e0100 { >> + compatible = "qcom,sdm845-aoss-reset"; >> + reg = <0xc2b0000 0x20004>; > > 0x20004 does seem very even, please verify this size. > even though the reg space after that range is unused, the AOSS reset driver is supposed to control only those listed reset lines >> + #reset-cells = <1>; >> +}; >> + >> + >> +Specifying reset lines connected to IP modules > > "AOSS reset clients" > yep this heading makes much more sense > Although you could probably get a way with just referring to reset.txt > and the header file. > >> +============================================== >> + >> +Device nodes that need access to reset lines should >> +specify them as a reset phandle in their corresponding node as >> +specified in reset.txt. >> + >> +For list of all valid reset indicies see >> +<dt-bindings/reset/qcom,sdm845-aoss.h> >> + >> +Example: >> + >> +modem-pil@4080000 { >> + ... >> + >> + resets = <&aoss_reset AOSS_CC_MSS_RESTART>; >> + reset-names = "mss_restart"; >> + >> + ... >> +}; >> diff --git a/include/dt-bindings/reset/qcom,sdm845-aoss.h b/include/dt-bindings/reset/qcom,sdm845-aoss.h >> new file mode 100644 >> index 0000000..e9b38fc >> --- /dev/null >> +++ b/include/dt-bindings/reset/qcom,sdm845-aoss.h >> @@ -0,0 +1,17 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > For tooling reasons header files should have their SPDX License tag > wrapped in /* */ > Sure will replace it >> +/* >> + * Copyright (C) 2018 The Linux Foundation. All rights reserved. >> + */ >> + >> +#ifndef _DT_BINDINGS_RESET_AOSS_SDM_845_H >> +#define _DT_BINDINGS_RESET_AOSS_SDM_845_H >> + >> +#define AOSS_CC_MSS_RESTART 0 >> +#define AOSS_CC_CAMSS_RESTART 1 >> +#define AOSS_CC_VENUS_RESTART 2 >> +#define AOSS_CC_GPU_RESTART 3 >> +#define AOSS_CC_DISPSS_RESTART 4 >> +#define AOSS_CC_WCSS_RESTART 5 >> +#define AOSS_CC_LPASS_RESTART 6 >> + >> +#endif > > Apart from these nits this looks reasonable. > > Regards, > Bjorn > -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc, is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-14 9:21 [PATCH v3 0/7] Add support for remoteproc modem-pil on " Sibi S 2018-03-14 9:21 ` [PATCH v3 1/7] dt-bindings: reset: Add AOSS reset bindings for " Sibi S 2018-03-18 12:49 ` Rob Herring 2018-03-18 22:44 ` Bjorn Andersson 2018-03-21 6:29 ` Sibi S [this message] 2018-03-14 9:21 ` [PATCH v3 2/7] reset: qcom: AOSS (always on subsystem) reset controller Sibi S 2018-03-14 10:48 ` Vivek Gautam 2018-03-18 22:45 ` Bjorn Andersson 2018-03-22 22:32 ` Sibi S 2018-03-14 9:21 ` [PATCH v3 3/7] dt-bindings: mailbox: Add APCS global binding for SDM845 SoCs Sibi S 2018-03-18 22:45 ` Bjorn Andersson 2018-03-14 9:21 ` [PATCH v3 4/7] mailbox: Add support for Qualcomm " Sibi S 2018-03-18 22:45 ` Bjorn Andersson 2018-04-19 17:22 ` Bjorn Andersson 2018-03-14 9:21 ` [PATCH v3 5/7] dt-bindings: remoteproc: Add Q6v5 Modem PIL binding for SDM845 Sibi S 2018-03-18 22:46 ` Bjorn Andersson 2018-03-14 9:21 ` [PATCH v3 6/7] remoteproc: qcom: Add support for mss remoteproc on SDM845 Sibi S 2018-03-14 9:21 ` [PATCH v3 7/7] remoteproc: qcom: Always assert and deassert reset signals in SDM845 Sibi S 2018-03-18 22:46 ` Bjorn Andersson 2018-03-22 22:10 ` Sibi S
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d5a7f0c0-5daa-d2ac-a383-9456e9e38e4f@codeaurora.org \ --to=sibis@codeaurora.org \ --cc=akdwived@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=georgi.djakov@linaro.org \ --cc=jassisinghbrar@gmail.com \ --cc=kyan@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=ohad@wizery.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=sricharan@codeaurora.org \ --cc=tsoni@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox