From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759978AbcINHNP (ORCPT ); Wed, 14 Sep 2016 03:13:15 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:11473 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755204AbcINHNM (ORCPT ); Wed, 14 Sep 2016 03:13:12 -0400 X-AuditID: cbfec7f5-f79ce6d000004c54-e6-57d8f884d065 Subject: Re: [PATCH 1/6] leds: gpio: fix an unhandled error case in create_gpio_led To: Heiner Kallweit Cc: "linux-leds@vger.kernel.org" , Linux Kernel Mailing List From: Jacek Anaszewski Message-id: Date: Wed, 14 Sep 2016 09:13:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <15945af0-24df-ff7c-73b7-7872dc5ed8bd@gmail.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7djPc7otP26EG3yfymux6P0MVovLu+aw WWx9s47Rgdlj56y77B6fN8kFMEVx2aSk5mSWpRbp2yVwZbx8OpG14B5PxYznq5kbGDdydTFy ckgImEh8+3WKCcIWk7hwbz1bFyMXh5DAUkaJz+33GCGcz4wSmz52s8J0PL95nBHEFhJYxijx 5LQnRNEzRolFPb3MIAlhgVCJvu+NLCC2iICWxITXa9hAbGaBSoldc/rZQWw2AUOJny9eg63m FbCT+HduMthQFgFViYsrtgDFOThEBSIkdt9NhSgRlPgx+R7YSE4BW4nz/5qZIUZaSTz718oK YctLbF7zlhnkHgmB92wSh86A7OIAcmQlNh1ghrjfReL8qv1QtrDEq+Nb2CFsGYnOjoNMEL2T GSUuHrvJCuGsZpTY2NnJAlFlLdHw/xcLxDY+iUnbpjNDLOCV6GgTgijxkHh+/BrUAkeJrvlH 2SGBdZhRYv3fwgmM8rOQ/DMLyQ+zkPywgJF5FaNIamlxbnpqsalecWJucWleul5yfu4mRmAi OP3v+NcdjEuPWR1iFOBgVOLhDfhxPVyINbGsuDL3EKMEB7OSCO+xrzfChXhTEiurUovy44tK c1KLDzFKc7AoifPuWXAlXEggPbEkNTs1tSC1CCbLxMEp1cDIN7Ey4FeXsM6P118v/AuXmTk1 peT44acFbW/j8huEVjfcOPKw6dLHtVuTXsfuk9g8T1BPa2nnW+9js56UdfjNV/7Gm8+Y9Xhd nP6C2mlZqywdBe1Kjq51NmK86a8gfHti1YRZCjKRconLAmxOvJx4jaPrz/mJb169ijoWnOLr Z26daVOYeW6REktxRqKhFnNRcSIA8NoAygADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42I5/e/4Nd2wHzfCDSZckbRY9H4Gq8XlXXPY LLa+WcfowOyxc9Zddo/Pm+QCmKLcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2UFPISc1NtlSJ0 fUOClBTKEnNKgTwjAzTg4BzgHqykb5fglvHy6UTWgns8FTOer2ZuYNzI1cXIySEhYCLx/OZx RghbTOLCvfVsXYxcHEICSxglVu5pZ4VwnjFKzDwymwWkSlggVKLveyOYLSKgJTHh9RqojsOM Epv3XgUbxSxQKfGs7TUbiM0mYCjx88VrJhCbV8BO4t+5yWA1LAKqEhdXbAGLiwpESNxa9ZER okZQ4sfke2ALOAVsJc7/a2aGmGkm8eXlYVYIW15i85q3zBMYBWYhaZmFpGwWkrIFjMyrGEVS S4tz03OLDfWKE3OLS/PS9ZLzczcxAiNj27Gfm3cwXtoYfIhRgINRiYc34Mf1cCHWxLLiytxD jBIczEoivMe+3ggX4k1JrKxKLcqPLyrNSS0+xGgK9MREZinR5Hxg1OaVxBuaGJpbGhoZW1iY GxkpifOWfLgSLiSQnliSmp2aWpBaBNPHxMEp1cAY2az7lH3mHPffV5+fN780Q8cuZn7hDt/w CR6qpmn+xeHWPcYqDWd4NwksOi9zvLNl7t3SjQLnzLPc0m41JH9o7q+c9iOnmMv2dF6f8brX pX+lmIIaX9lqWXCeqZXiqP/2Z8snwfpL11MM2dLNVf4GBr260DKzgUd/65P/s5YJzfhXcSN4 3S8lluKMREMt5qLiRACA5h47ogIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160914071307eucas1p2bdc3efef2b16adbc995ce56cec7a7761 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160913185832eucas1p2d66fec4689db17f211d2557fe426e3d2 X-RootMTR: 20160913185832eucas1p2d66fec4689db17f211d2557fe426e3d2 References: <5432fb03-ea18-a949-ce53-10fedc15f5d9@gmail.com> <15945af0-24df-ff7c-73b7-7872dc5ed8bd@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiner, You dropped also patch 1/8 from the first version of the patch set but patch 2/6 from this series seems to be based on this change, which causes conflict when trying to apply it. Please also don't forget to add version number to the PATCH tag. On 09/13/2016 08:53 PM, Heiner Kallweit wrote: > gpiod_get_value_cansleep returns 0, 1, or an error code. > So far errors are not handled and treated the same as 1. > Change this to bail out if an error code is returned and > remove the double negation. > > Signed-off-by: Heiner Kallweit > --- > drivers/leds/leds-gpio.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index 3599b2e..10c851e 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -118,10 +118,13 @@ static int create_gpio_led(const struct gpio_led *template, > led_dat->platform_gpio_blink_set = blink_set; > led_dat->cdev.blink_set = gpio_blink_set; > } > - if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP) > - state = !!gpiod_get_value_cansleep(led_dat->gpiod); > - else > + if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP) { > + state = gpiod_get_value_cansleep(led_dat->gpiod); > + if (state < 0) > + return state; > + } else { > state = (template->default_state == LEDS_GPIO_DEFSTATE_ON); > + } > led_dat->cdev.brightness = state ? LED_FULL : LED_OFF; > if (!template->retain_state_suspended) > led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; > -- Best regards, Jacek Anaszewski