LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pali@kernel.org" <pali@kernel.org>,
	"dsterba@suse.cz" <dsterba@suse.cz>,
	"aaptel@suse.com" <aaptel@suse.com>,
	"willy@infradead.org" <willy@infradead.org>,
	"rdunlap@infradead.org" <rdunlap@infradead.org>,
	"joe@perches.com" <joe@perches.com>,
	"mark@harmstone.com" <mark@harmstone.com>,
	"nborisov@suse.com" <nborisov@suse.com>,
	"linux-ntfs-dev@lists.sourceforge.net" 
	<linux-ntfs-dev@lists.sourceforge.net>,
	"anton@tuxera.com" <anton@tuxera.com>,
	"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
	"hch@lst.de" <hch@lst.de>
Subject: RE: [PATCH v14 06/10] fs/ntfs3: Add compression
Date: Fri, 11 Dec 2020 16:28:15 +0000
Message-ID: <d5b485fa9ced4923a47704c9ec19552e@paragon-software.com> (raw)
In-Reply-To: <X8qCLXJOit0M+4X7@sol.localdomain>

From: Eric Biggers <ebiggers@kernel.org>
Sent: Friday, December 4, 2020 9:39 PM
> To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> Cc: linux-fsdevel@vger.kernel.org; viro@zeniv.linux.org.uk; linux-kernel@vger.kernel.org; pali@kernel.org; dsterba@suse.cz;
> aaptel@suse.com; willy@infradead.org; rdunlap@infradead.org; joe@perches.com; mark@harmstone.com; nborisov@suse.com;
> linux-ntfs-dev@lists.sourceforge.net; anton@tuxera.com; dan.carpenter@oracle.com; hch@lst.de
> Subject: Re: [PATCH v14 06/10] fs/ntfs3: Add compression
> 
> On Fri, Dec 04, 2020 at 06:45:56PM +0300, Konstantin Komarov wrote:
> > This adds compression
> >
> > Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> > ---
> >  fs/ntfs3/lib/common_defs.h       | 196 +++++++++++
> >  fs/ntfs3/lib/decompress_common.c | 314 +++++++++++++++++
> >  fs/ntfs3/lib/decompress_common.h | 558 +++++++++++++++++++++++++++++++
> >  fs/ntfs3/lib/lzx_common.c        | 204 +++++++++++
> >  fs/ntfs3/lib/lzx_common.h        |  31 ++
> >  fs/ntfs3/lib/lzx_constants.h     | 113 +++++++
> >  fs/ntfs3/lib/lzx_decompress.c    | 553 ++++++++++++++++++++++++++++++
> >  fs/ntfs3/lib/xpress_constants.h  |  23 ++
> >  fs/ntfs3/lib/xpress_decompress.c | 165 +++++++++
> >  fs/ntfs3/lznt.c                  | 452 +++++++++++++++++++++++++
> >  10 files changed, 2609 insertions(+)
> >  create mode 100644 fs/ntfs3/lib/common_defs.h
> >  create mode 100644 fs/ntfs3/lib/decompress_common.c
> >  create mode 100644 fs/ntfs3/lib/decompress_common.h
> >  create mode 100644 fs/ntfs3/lib/lzx_common.c
> >  create mode 100644 fs/ntfs3/lib/lzx_common.h
> >  create mode 100644 fs/ntfs3/lib/lzx_constants.h
> >  create mode 100644 fs/ntfs3/lib/lzx_decompress.c
> >  create mode 100644 fs/ntfs3/lib/xpress_constants.h
> >  create mode 100644 fs/ntfs3/lib/xpress_decompress.c
> >  create mode 100644 fs/ntfs3/lznt.c
> 
> This really could use a much better commit message.  Including mentioning where
> the LZX and XPRESS decompression code came from
> (https://github.com/ebiggers/ntfs-3g-system-compression).
> 

Hi Eric! Fixed in V15!

> Also note you've marked the files as "SPDX-License-Identifier: GPL-2.0",
> but they really are "SPDX-License-Identifier: GPL-2.0-or-later".
> 

Thanks, fixed as well.

> Also I still think you should consider using the simpler version from
> ntfs-3g-system-compression commit 3ddd227ee8e3, which I had originally intended
> to be included in NTFS-3G itself.  That version was fewer lines of code and
> fewer files, as it was simplified for decompression-only.  The latest version
> (the one you're using) is shared with a project that also implements compression
> (so that I can more easily maintain both projects), so it's more complex than
> needed for decompression-only support.  But in the kernel context it may make
> sense to go with a simpler version.  There are a few performance optimizations
> you'd miss by going with the older version, but they weren't too significant,
> and probably you don't need to squeeze out every bit of performance possible
> when reading XPRESS and LZX-compressed files in this context?
> 
> - Eric

We used the newest code initially. Looking at the commit you've pointed out, but it will
take some time as needs to pass full set of tests with new code. On the differences you've
mentioned between the first and latest code in ntfs-3g system compression: we've removed
the optimizations (needed to go into kernel), also the reparse points stuff is being parsed by
ntfs3 driver itself. Given this, doesn't seems there are many differences remain.
Also, we'll follow your recommendations, if you highly recommend to stick to the commit
you've mentioned (but at this moment it seems "newer=better" formula still valid).

Thanks!

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 15:45 [PATCH v14 00/10] NTFS read-write driver GPL implementation by Paragon Software Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 01/10] fs/ntfs3: Add headers and misc files Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 02/10] fs/ntfs3: Add initialization of super block Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 03/10] fs/ntfs3: Add bitmap Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 04/10] fs/ntfs3: Add file operations and implementation Konstantin Komarov
2020-12-04 18:41   ` Eric Biggers
2020-12-11 16:31     ` Konstantin Komarov
2020-12-25 14:27       ` Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 05/10] fs/ntfs3: Add attrib operations Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 06/10] fs/ntfs3: Add compression Konstantin Komarov
2020-12-04 18:38   ` Eric Biggers
2020-12-11 16:28     ` Konstantin Komarov [this message]
2020-12-25 14:29       ` Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 07/10] fs/ntfs3: Add NTFS journal Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 08/10] fs/ntfs3: Add Kconfig, Makefile and doc Konstantin Komarov
2020-12-04 15:45 ` [PATCH v14 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile Konstantin Komarov
2020-12-04 18:51   ` kernel test robot
2020-12-05  0:41   ` kernel test robot
2020-12-04 15:46 ` [PATCH v14 10/10] fs/ntfs3: Add MAINTAINERS Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5b485fa9ced4923a47704c9ec19552e@paragon-software.com \
    --to=almaz.alexandrovich@paragon-software.com \
    --cc=aaptel@suse.com \
    --cc=anton@tuxera.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=ebiggers@kernel.org \
    --cc=hch@lst.de \
    --cc=joe@perches.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=mark@harmstone.com \
    --cc=nborisov@suse.com \
    --cc=pali@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git