From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbcFUI0a (ORCPT ); Tue, 21 Jun 2016 04:26:30 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35196 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbcFUI00 (ORCPT ); Tue, 21 Jun 2016 04:26:26 -0400 Subject: Re: [PATCH V7 8/8] irqchip/gicv3-its: Use MADT ITS subtable to do PCI/MSI domain initialization To: Tomasz Nowicki , marc.zyngier@arm.com, tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, bhelgaas@google.com, lorenzo.pieralisi@arm.com, robert.richter@caviumnetworks.com, shijie.huang@arm.com, Suravee.Suthikulpanit@amd.com References: <1466420541-20101-1-git-send-email-tn@semihalf.com> <1466420541-20101-9-git-send-email-tn@semihalf.com> Cc: al.stone@linaro.org, mw@semihalf.com, graeme.gregory@linaro.org, Catalin.Marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ddaney.cavm@gmail.com, okaya@codeaurora.org, andrea.gallo@linaro.org, linux-pci@vger.kernel.org From: Hanjun Guo Message-ID: Date: Tue, 21 Jun 2016 16:19:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466420541-20101-9-git-send-email-tn@semihalf.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/6/20 19:02, Tomasz Nowicki wrote: > Let ACPI build ITS PCI MSI domain. ACPI code is responsible for retrieving > inner domain token and passing it on to its_pci_msi_init_one generic > init call. > > IORT maintains list of registered domain tokens and allows to find > corresponding domain based on MADT ITS subtable ID info. > > Signed-off-by: Tomasz Nowicki > Acked-by: Marc Zyngier > --- > drivers/irqchip/irq-gic-v3-its-pci-msi.c | 44 ++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c > index d2c2496..ae7221c 100644 > --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c > +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c > @@ -15,6 +15,7 @@ > * along with this program. If not, see . > */ > > +#include > #include > #include > #include > @@ -144,9 +145,52 @@ static int __init its_pci_of_msi_init(void) > return 0; > } > > +#ifdef CONFIG_ACPI > + > +static int __init > +its_pci_msi_parse_madt(struct acpi_subtable_header *header, > + const unsigned long end) > +{ > + struct acpi_madt_generic_translator *its_entry; > + struct fwnode_handle *dom_handle; > + const char *node_name; > + int err = -ENXIO; > + > + its_entry = (struct acpi_madt_generic_translator *)header; > + node_name = kasprintf(GFP_KERNEL, "ITS@0x%lx", > + (long)its_entry->base_address); > + dom_handle = iort_find_domain_token(its_entry->translation_id); > + if (!dom_handle) { > + pr_err("%s: Unable to locate ITS domain handle\n", node_name); > + goto out; > + } > + > + err = its_pci_msi_init_one(dom_handle, node_name); > + if (!err) > + pr_info("PCI/MSI: %s domain created\n", node_name); > + > +out: > + kfree(node_name); > + return err; > +} > + > +static int __init its_pci_acpi_msi_init(void) > +{ > + acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR, > + its_pci_msi_parse_madt, 0); > + return 0; > +} > +#else > +static int __init its_pci_acpi_msi_init(void) > +{ > + return 0; > +} > +#endif > + > static int __init its_pci_msi_init(void) > { > its_pci_of_msi_init(); > + its_pci_acpi_msi_init(); > > return 0; > } Reviewed-by: Hanjun Guo Thanks Hanjun