From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CC2C77B61 for ; Thu, 23 Mar 2023 19:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbjCWTxW (ORCPT ); Thu, 23 Mar 2023 15:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjCWTxT (ORCPT ); Thu, 23 Mar 2023 15:53:19 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5E29C14D; Thu, 23 Mar 2023 12:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=oc/iUo0lIBe+FS5WVSyueoHdxi6tsJxX0Ez4lN9w4K8=; b=yVdVBQAOM+Q4pyNSb2udc1HKJ0 PJPKMWoeesWKoYQ3VsCuDYywal3A5xt53IIOwb0AIaGSynK+56rNvANbWobJtF7/x66vIobFT2hnO XXfGKYN9+lKEFnxV5Gsls/N5g1xnsjwOQjKVOquRy9QutcLVLjpeDXtWxpUVzxtbb6t4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pfQze-008EUF-F2; Thu, 23 Mar 2023 20:53:02 +0100 Date: Thu, 23 Mar 2023 20:53:02 +0100 From: Andrew Lunn To: Pavel Machek Cc: Christian Marangi , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 15/15] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Message-ID: References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-16-ansuelsmth@gmail.com> <318f65ef-fd63-446d-bd08-1ba51b1d1f72@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Hi Pavel > > > > It is just a plain boring LED, so it will look like all other LEDs. > > There is nothing special here. > > Well, AFAICT it will end up as /sys/class/leds/WAN, which is really > not what we want. Why not? It is just a plain boring LED. It can be used for anything, heartbeat, panic SOS in Morse code, shift lock, disk activity. Any of the triggers can be applied to it. It can be found in /sys/class/leds/f1072004.mdio-mii:00:WAN. But when we come to using it for ledtrig-netdev, the user is more likely to follow /sys/class/net/eth0/phydev/leds/f1072004.mdio-mii\:00\:WAN/ > (Plus the netdev trigger should be tested; we'll > need some kind of link to the ethernet device if we want this to work > on multi-ethernet systems). Since this is a plain boring LED, it could actually blink for any netdev. When we get to offloading blinking to hardware, then things change, we need to check the netdev which is configured in the ledtrig-netdev is the same one the PHY is associated to. But i have a patchset for that which will appear later. > Should documentation be added to Documentation/leds/well-known-leds.txt ? Saying what. That there might be LEDs in your RJ45 connector, which can be used for anything which is supported by an Linux LED trigger? Andrew