From: Jiada Wang <jiada_wang@mentor.com>
To: Rob Herring <robh@kernel.org>
Cc: <geert+renesas@glider.be>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <horms@verge.net.au>, <magnus.damm@gmail.com>,
<mark.rutland@arm.com>, <linux-kernel@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock
Date: Fri, 26 Oct 2018 11:32:36 +0900 [thread overview]
Message-ID: <d6053012-85b1-3fbf-c35b-c5c5816e9fa8@mentor.com> (raw)
In-Reply-To: <20181025214925.GA5197@bogus>
Hi Rob
On 2018/10/26 6:49, Rob Herring wrote:
> On Thu, Oct 25, 2018 at 04:23:47PM +0900, jiada_wang@mentor.com wrote:
>> From: Jiada Wang <jiada_wang@mentor.com>
>>
>> Add device tree bindings for avb counter clock for Renesas
>> R-Car Socs.
>>
>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>> ---
>> .../bindings/clock/renesas,avb-clk.txt | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/renesas,avb-clk.txt
>>
>> diff --git a/Documentation/devicetree/bindings/clock/renesas,avb-clk.txt b/Documentation/devicetree/bindings/clock/renesas,avb-clk.txt
>> new file mode 100644
>> index 000000000000..03bf50b5830c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/renesas,avb-clk.txt
>> @@ -0,0 +1,19 @@
>> +* Renesas AVB Counter Clock
>> +
>> +The AVB Counter Clocks are provided by avb_counter8 Clock Generator,
>> +avb_counter8 has dividers which operates with S0D1ϕ clock and has
>> +8 output clocks.
>> +
>> +Required Properties:
>> + - compatible: Must be "renesas,clk-avb"
> Should be SoC specific?
yes, avb counter clock is SoC specific, I will move avb clock node to
Soc .dtsi in next version
>
> If the h/w block is called "AVB Counter" then use "avb-counter" in the
> compatible string.
will update compatible string
>> + - reg: Base address and length of the memory resource used by the AVB
>> + - #clock-cells: Must be 1
>> +
>> +Example
>> +-------
>> +
>> + clk_avb: avb-clock@ec5a011c {
> clock-controller@...
will replace with "clock-controller"
Thanks,
Jiada
>
>> + compatible = "renesas,clk-avb";
>> + reg = <0 0xec5a011c 0 0x24>;
>> + #clock-cells = <1>;
>> + };
>> --
>> 2.17.0
>>
next prev parent reply other threads:[~2018-10-26 2:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 7:23 [PATCH linux-next v1 0/4] Add AVB Counter Clock jiada_wang
2018-10-25 7:23 ` [PATCH linux-next v1 1/4] clk: renesas: clk-avb: add AVB Clock driver jiada_wang
2018-10-29 18:34 ` Stephen Boyd
2018-10-25 7:23 ` [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock jiada_wang
2018-10-25 21:49 ` Rob Herring
2018-10-26 2:32 ` Jiada Wang [this message]
2018-10-29 13:14 ` Rob Herring
2018-10-29 18:29 ` Stephen Boyd
2018-10-31 12:00 ` Jiada Wang
2018-11-04 3:14 ` Stephen Boyd
2018-11-22 7:06 ` Jiada Wang
2018-11-27 21:59 ` Stephen Boyd
2018-10-25 7:23 ` [PATCH linux-next v1 3/4] arm64: ulcb: Add avb counter clock jiada_wang
2018-10-25 20:22 ` Geert Uytterhoeven
2018-10-26 2:19 ` Jiada Wang
2018-10-25 7:23 ` [PATCH linux-next v1 4/4] arm64: salvator-common: " jiada_wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6053012-85b1-3fbf-c35b-c5c5816e9fa8@mentor.com \
--to=jiada_wang@mentor.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).