From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>, Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2] nvme: avoid race in shutdown namespace removal
Date: Mon, 6 Sep 2021 10:40:05 +0200 [thread overview]
Message-ID: <d63a15af-63a7-3fa0-1559-4518dee3a99a@suse.de> (raw)
In-Reply-To: <YTXKwOvCtJOHnhpu@infradead.org>
On 9/6/21 10:01 AM, Christoph Hellwig wrote:
> On Thu, Sep 02, 2021 at 11:20:02AM +0200, Daniel Wagner wrote:
>> When we remove the siblings entry, we update ns->head->list, hence we
>> can't separate the removal and test for being empty. They have to be
>> in the same critical section to avoid a race.
>>
>> To avoid breaking the refcounting imbalance again, add a list empty
>> check to nvme_find_ns_head.
>
> Hannes, can you look over this and run your tests on it?
>
I'm at it.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-09-06 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 9:20 [PATCH v2] nvme: avoid race in shutdown namespace removal Daniel Wagner
2021-09-06 8:01 ` Christoph Hellwig
2021-09-06 8:40 ` Hannes Reinecke [this message]
2021-09-09 10:06 ` Hannes Reinecke
2021-09-09 14:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d63a15af-63a7-3fa0-1559-4518dee3a99a@suse.de \
--to=hare@suse.de \
--cc=dwagner@suse.de \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).