From: Conor Dooley <mail@conchuod.ie>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Conor Dooley <Conor.Dooley@microchip.com>
Cc: Wolfram Sang <wsa@kernel.org>,
Daire.McNamara@microchip.com, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
Date: Thu, 24 Feb 2022 13:49:53 +0000 [thread overview]
Message-ID: <d64555a6-79ce-bff0-bb06-bc0b02fa27ff@conchuod.ie> (raw)
In-Reply-To: <CAMuHMdV5ghvAze-zOVAm9LSv9261PE0hh3nxyv5db18azmo2=w@mail.gmail.com>
On 24/02/2022 13:34, Geert Uytterhoeven wrote:
> Hi Conor,
>
> On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote:
>> On 24/02/2022 12:58, Geert Uytterhoeven wrote:
>>> On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
>>>> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
>>>>> make dt_binding_check:
>>>>>
>>>>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>>>>
>>>> Hey Geert,
>>>> I've run dt_binding_check locally but I dont get a warning, is there
>>>> something I am missing?
>>>
>>> Interesting. Are you using the latest dtschema?
>>> https://github.com/devicetree-org/dt-schema.git
>>
>> I was on v2021.12, but have now tried v2022.01 & master
>> (2022.2.dev1+gf677c85).
>>
>> Is there something other than running "make dt_binding_check" in a fresh
>> checkout that I need to do?
>
> You did update your installation after the fresh[1] checkout?
>
> $ cd dt-schema
> $ pip3 install -e .
>
> [1] What about "git pull"? ;-)
>
I went for the option of "pip3 install
git+https://github.com/devicetree-org/dt-schema.git@master"
If I alter check_dtschema_version to spit out the version, its as
expected. The checkout was of Linux not the dt-schema.
I have found the issue however, realised just before Rob pointed it out
that I missed yamllint when I reinstalled my OS recently.
next prev parent reply other threads:[~2022-02-24 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 12:31 [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items Geert Uytterhoeven
2022-02-24 12:55 ` Conor.Dooley
2022-02-24 12:58 ` Geert Uytterhoeven
2022-02-24 13:15 ` Conor.Dooley
2022-02-24 13:34 ` Geert Uytterhoeven
2022-02-24 13:43 ` Rob Herring
2022-02-24 13:51 ` Conor Dooley
2022-02-24 13:49 ` Conor Dooley [this message]
2022-02-24 13:44 ` Rob Herring
2022-03-01 7:52 ` Conor.Dooley
2022-03-01 15:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d64555a6-79ce-bff0-bb06-bc0b02fa27ff@conchuod.ie \
--to=mail@conchuod.ie \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).