From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2D42C04A68 for ; Thu, 28 Jul 2022 07:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234665AbiG1Hnl (ORCPT ); Thu, 28 Jul 2022 03:43:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234641AbiG1Hnh (ORCPT ); Thu, 28 Jul 2022 03:43:37 -0400 X-Greylist: delayed 187 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 28 Jul 2022 00:43:36 PDT Received: from smtp86.ord1d.emailsrvr.com (smtp86.ord1d.emailsrvr.com [184.106.54.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4394461109 for ; Thu, 28 Jul 2022 00:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=openvpn.net; s=20170822-45nk5nwl; t=1658994214; bh=COnHq0q10jhFOxbkwvLuP4sHO7hzKD2UTU9fvogld5o=; h=Date:Subject:To:From:From; b=imTyKsUTDpVzxEuwveDG9Vi/iPpqKWnZg0vHRucblp1d5tQO6MuTx+7WB+8L2f2dk YW9WYmM4V2DSzo6pGqIjf7+RQEdfKJZq1B33HaqSQhxGDR/ErZ21+856eJAyrStgrV eaPQ4qTYUGlrESkf2GsmhGL5N4yvZI+rwrVuiJxg= X-Auth-ID: antonio@openvpn.net Received: by smtp3.relay.ord1d.emailsrvr.com (Authenticated sender: antonio-AT-openvpn.net) with ESMTPSA id 9B1F460090; Thu, 28 Jul 2022 03:43:33 -0400 (EDT) Message-ID: Date: Thu, 28 Jul 2022 09:44:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco) Content-Language: en-US To: Andrew Lunn Cc: netdev@vger.kernel.org, David Miller , Jakub Kicinski , linux-kernel@vger.kernel.org References: <20220719014704.21346-1-antonio@openvpn.net> <20220719014704.21346-2-antonio@openvpn.net> From: Antonio Quartulli Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: 8cf5a843-5e45-45b4-8822-23f11e9ecabf-1-1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19/07/2022 17:37, Andrew Lunn wrote: >> +static int ovpn_net_change_mtu(struct net_device *dev, int new_mtu) >> +{ >> + if (new_mtu < IPV4_MIN_MTU || >> + new_mtu + dev->hard_header_len > IP_MAX_MTU) >> + return -EINVAL; > > If you set dev->min_mtu and dev->max_mtu, the core will validate this > for you, see dev_validate_mtu(). Yeah, thanks for the pointer. > >> +static int ovpn_get_link_ksettings(struct net_device *dev, >> + struct ethtool_link_ksettings *cmd) >> +{ >> + ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported, 0); >> + ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.advertising, 0); > > These two should not be needed. Look at tun, veth etc, they don't set > them. I found this in tun.c: 3512 ethtool_link_ksettings_zero_link_mode(cmd, supported); 3513 ethtool_link_ksettings_zero_link_mode(cmd, advertising); Which seems a more appropriate version of my code, no? Regards, -- Antonio Quartulli OpenVPN Inc.