linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>,
	catalin.marinas@arm.com, will.deacon@arm.com,
	akpm@linux-foundation.org, rppt@linux.vnet.ibm.com,
	mhocko@suse.com, ard.biesheuvel@linaro.org,
	andrew.murray@arm.com, james.morse@arm.com, sboyd@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] arm64: Early boot time stamps
Date: Tue, 20 Nov 2018 11:29:27 +0000	[thread overview]
Message-ID: <d66a60d9-6772-a951-9da4-c07443b48aad@arm.com> (raw)
In-Reply-To: <20181119214443.25175-2-pasha.tatashin@soleen.com>

Hi Pavel,

On 19/11/2018 21:44, Pavel Tatashin wrote:
> Allow printk time stamps/sched_clock() to be available from the early
> boot.
> 
> Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> ---
>  arch/arm64/kernel/setup.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index f4fc1e0544b7..4df41a66b403 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -40,6 +40,7 @@
>  #include <linux/efi.h>
>  #include <linux/psci.h>
>  #include <linux/sched/task.h>
> +#include <linux/sched_clock.h>
>  #include <linux/mm.h>
>  
>  #include <asm/acpi.h>
> @@ -279,8 +280,26 @@ arch_initcall(reserve_memblock_reserved_regions);
>  
>  u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID };
>  
> +/*
> + * Get time stamps available early in boot, useful to identify boot time issues
> + * from the early boot.
> + */
> +static __init void sched_clock_early_init(void)
> +{
> +	u64 freq = arch_timer_get_cntfrq();
> +	u64 (*read_time)(void) = arch_counter_get_cntvct;

We already have arch_timer_read_counter which is exposed from
arm_arch_timer.h.

> +
> +	/* Early clock is available only on platforms with known freqs */

This comment is misleading. It should read something like:

	/*
	 * The arm64 boot protocol mandates that CNTFRQ_EL0 reflects
	 * the timer frequency. To avoid breakage on misconfigured
	 * systems, do not register the early sched_clock if the
	 * programmed value if zero. Other random values will just
	 * result in random output.
	 */

> +	if (!freq)
> +		return;
> +
> +	sched_clock_register(read_time, BITS_PER_LONG, freq);

This doesn't seem right. The counter has an architected minimum of 56
bits, and you can't assume that it is going to be more than that.

> +}
> +
>  void __init setup_arch(char **cmdline_p)
>  {
> +	sched_clock_early_init();
> +
>  	init_mm.start_code = (unsigned long) _text;
>  	init_mm.end_code   = (unsigned long) _etext;
>  	init_mm.end_data   = (unsigned long) _edata;
> 

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2018-11-20 11:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 21:44 [PATCH v1 0/1] Early boot time stamps for arm64 Pavel Tatashin
2018-11-19 21:44 ` [PATCH v1 1/1] arm64: Early boot time stamps Pavel Tatashin
2018-11-20 11:29   ` Marc Zyngier [this message]
2018-11-20 14:40     ` Pavel Tatashin
2018-11-20 14:53       ` Andrew Murray
2018-11-20 14:55       ` Marc Zyngier
2018-11-20 15:03         ` Pavel Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d66a60d9-6772-a951-9da4-c07443b48aad@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.murray@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=sboyd@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).