From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FEDC4338F for ; Thu, 29 Jul 2021 09:05:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E42A261059 for ; Thu, 29 Jul 2021 09:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235387AbhG2JFD (ORCPT ); Thu, 29 Jul 2021 05:05:03 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3517 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234972AbhG2JFC (ORCPT ); Thu, 29 Jul 2021 05:05:02 -0400 Received: from fraeml703-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Gb4B517Xdz6FFxM; Thu, 29 Jul 2021 16:55:41 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml703-chm.china.huawei.com (10.206.15.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 29 Jul 2021 11:04:57 +0200 Received: from [10.47.27.169] (10.47.27.169) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 10:04:56 +0100 Subject: Re: [PATCH v2 24/24] iommu: Only log strictness for DMA domains To: Robin Murphy , , CC: , , , , , References: From: John Garry Message-ID: Date: Thu, 29 Jul 2021 10:04:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.27.169] X-ClientProxiedBy: lhreml745-chm.china.huawei.com (10.201.108.195) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2021 16:58, Robin Murphy wrote: > When passthrough is enabled, the default strictness policy becomes > irrelevant, since any subsequent runtime override to a DMA domain type > now embodies an explicit choice of strictness as well. Save on noise by > only logging the default policy when it is meaningfully in effect. > > Signed-off-by: Robin Murphy FWIW, small comment below, Reviewed-by: John Garry > --- > drivers/iommu/iommu.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index be399d630953..87d7b299436e 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -144,10 +144,11 @@ static int __init iommu_subsys_init(void) > (iommu_cmd_line & IOMMU_CMD_LINE_DMA_API) ? > "(set via kernel command line)" : ""); > > - pr_info("DMA domain TLB invalidation policy: %s mode %s\n", > - iommu_dma_strict ? "strict" : "lazy", > - (iommu_cmd_line & IOMMU_CMD_LINE_STRICT) ? > - "(set via kernel command line)" : ""); > + if (!iommu_default_passthrough()) I suppose that you could also do an early return to save indenting... > + pr_info("DMA domain TLB invalidation policy: %s mode %s\n", > + iommu_dma_strict ? "strict" : "lazy", > + (iommu_cmd_line & IOMMU_CMD_LINE_STRICT) ? > + "(set via kernel command line)" : ""); > > return 0; > }