From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754646AbdKINE2 (ORCPT ); Thu, 9 Nov 2017 08:04:28 -0500 Received: from mout.web.de ([212.227.15.3]:53615 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbdKINE0 (ORCPT ); Thu, 9 Nov 2017 08:04:26 -0500 Subject: Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work() To: Pavel Machek , linux-pm@vger.kernel.org Cc: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Sebastian Reichel , LKML , kernel-janitors@vger.kernel.org References: <48b34d35-8c41-d25b-0cb7-6257b37c5a44@users.sourceforge.net> <20171109120842.GA28552@atrey.karlin.mff.cuni.cz> From: SF Markus Elfring Message-ID: Date: Thu, 9 Nov 2017 14:04:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171109120842.GA28552@atrey.karlin.mff.cuni.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LgWWXedt4bjyh2dCiL6AoU/B5NjPkNvdKnwLOZukH3xEgekl8+H Z7hrseExGVIwe68p/AwJ+KEin0x3bVSLFuhrzV2vbIdgJuWQkah0iadqa2ma07meO2bXep9 sOhrXaM9sYysbnITaLa4b9s11N3sl1st+eOlhrZe2fF/IwmGfQxVVwZrLJ1nGQGBbU57DIF SQBYd7o9jT4H7a6to9u2w== X-UI-Out-Filterresults: notjunk:1;V01:K0:ON9vNYs5s7A=:tkLua2Wgp8Zf/4AYnw1loP zloNGXmdTQ7IHUfZbdxaRUGNc/0PwRUw7c5IZlUvILHsOnJKzgC2BiYaR3gPs6eZNrNfAPPY7 I+Q7+7DlTOxSTLBsdSAOK3whVfWOHrq4iPrZUBhm1LQyk6LMM2eF7nVAxPRW7+Xy81ZERjX8j QKHpVL2Y394BrEyBqLcSY78VELUlfmIpLoJZdrDulGlKGrY3j9LbMHwgO8H7gZkJFH4I032p1 S0+KhLMQeDJ9qTtYPctR0MXCAr8BIPZrX6PCoEfOgVg3/hYfDHKaIloPWgRkNuCmLMu7hsh2m ZBPX/UXAgJqWDCwjIbxD8zC15Ohb2QVxtfzHQRgHQWp94W5UhoCqsv1I3puNMhBgq5+84rzGv eg6whpP6Qu7BGmjvOKh6wxX7TnJnAWmrgCl341trktEPZFjfzJKWsWf4ZhG1qTm+OZcZQNliA ip8Cu+OqT9JOZa8vdwWXvI1SYHV/R5iUSCdc2J3WXg6eIdXhydIjfm3B4Is0IO+YvbTqxXk1S 8hjohm3iCIf3yPK8qXQ0WoObnc+3JZKV0TsgA12Z0T7+bdSGoSZuLAjtn16TOsPQ8NjtbgFC8 cdztm8MBEag+JGTXR7HNkK88aX77R1XOvDjXOKowfu4kAb84UuE6NAXleiGG4uz2DMbHG45TL yWqVFZNdxGKH2qbCTSuGi9UVpvVU6Egdg15/gJShmD2eN22oIyLdIyENOmsMAXQR+YB4ZpBzo SC2ZdmA0IfNzpwQJWAABacIBPryFDPP6jFGcNViqyp7xdYTFzcghbxO/XHDuYrQDHbcM32UMM 9TUQWxxT47xnrfu1sN7JdXE//5MtsjRxWN8jiVDTr1saRVL0IY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Better fix would be to display separate messages; user is probably > interested in what failed... Which information (or wording) would you find more appropriate at these places? Regards, Markus