From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Kathiravan T <kathirav@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 06/10] ARM: dts: qcom: msm8974: override nodes by label
Date: Mon, 18 Apr 2022 17:10:27 +0200 [thread overview]
Message-ID: <d68442c5-f1ed-d502-aae5-2770f9653c81@linaro.org> (raw)
In-Reply-To: <20220401201035.189106-7-krzysztof.kozlowski@linaro.org>
On 01/04/2022 22:10, Krzysztof Kozlowski wrote:
> Using node paths to extend or override a device tree node is error
> prone. If there was a typo error, a new node will be created instead of
> extending the existing node. This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time). This also reduces the indentation making the code
> easier to read.
>
> Re-order the overrides by label name. The pre/post DTBS are the same.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 614 +++++-----
> .../boot/dts/qcom-msm8974-fairphone-fp2.dts | 581 +++++----
> .../qcom-msm8974-lge-nexus5-hammerhead.dts | 1075 ++++++++--------
> .../boot/dts/qcom-msm8974-samsung-klte.dts | 1083 ++++++++---------
> .../dts/qcom-msm8974-sony-xperia-amami.dts | 569 +++++----
> .../dts/qcom-msm8974-sony-xperia-castor.dts | 908 +++++++-------
> .../dts/qcom-msm8974-sony-xperia-honami.dts | 636 +++++-----
> arch/arm/boot/dts/qcom-msm8974.dtsi | 16 +-
> 8 files changed, 2730 insertions(+), 2752 deletions(-)
>
Hi Bjorn,
I see you applied other arm-dts patches from this set, except this one.
Any comments here? This is quite a big one, so maybe it had trouble
making through the discussion lists?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-18 15:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 20:10 [PATCH 00/10] qcom: convert to dtschema qcom,smd and qcom,rpmcc Krzysztof Kozlowski
2022-04-01 20:10 ` [PATCH 01/10] arm64: dts: qcom: msm8953: do not use underscore in node name Krzysztof Kozlowski
2022-04-01 20:10 ` [PATCH 02/10] arm64: dts: qcom: msm8994: remove SMD qcom,local-pid property Krzysztof Kozlowski
2022-04-01 20:10 ` [PATCH 03/10] arm64: dts: qcom: add RPM clock controller fallback compatible Krzysztof Kozlowski
2022-04-01 20:10 ` [PATCH 04/10] ARM: dts: qcom: msm8974-lge-nexus5: move gpio-keys out of soc Krzysztof Kozlowski
2022-04-01 20:10 ` [PATCH 05/10] ARM: dts: qcom: msm8974-samsung-klte: " Krzysztof Kozlowski
2022-04-01 20:10 ` [PATCH 06/10] ARM: dts: qcom: msm8974: override nodes by label Krzysztof Kozlowski
2022-04-18 15:10 ` Krzysztof Kozlowski [this message]
2022-04-01 20:10 ` [PATCH 07/10] ARM: dts: qcom: do not use underscore in node name Krzysztof Kozlowski
2022-04-01 20:10 ` [PATCH 08/10] dt-bindings: soc: qcom,smd: convert to dtschema Krzysztof Kozlowski
2022-04-02 13:46 ` Rob Herring
2022-04-02 14:54 ` Krzysztof Kozlowski
2022-04-04 22:27 ` Rob Herring
2022-04-01 20:10 ` [PATCH 09/10] dt-bindings: clock: qcom,rpmcc: " Krzysztof Kozlowski
2022-04-04 22:29 ` Rob Herring
2022-04-01 20:10 ` [PATCH 10/10] dt-bindings: clock: qcom,rpmcc: add clocks property Krzysztof Kozlowski
2022-04-04 22:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68442c5-f1ed-d502-aae5-2770f9653c81@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathirav@codeaurora.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).