From: Michael Walle <michael@walle.cc>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] dt-bindings: net: phy: Add support for AT803X
Date: Thu, 31 Oct 2019 18:14:16 +0100 [thread overview]
Message-ID: <d68a8bef6f7d5193e7d373311c8045d7@walle.cc> (raw)
In-Reply-To: <b2c1988e-ffa7-ca13-081f-3d7f18c31233@gmail.com>
Am 2019-10-31 17:45, schrieb Florian Fainelli:
> On 10/30/19 5:14 PM, Michael Walle wrote:
>>> So we can later add atheros,rgmii-io-2v5. That might need a regulator
>>> as well. Maybe add that 2.5V is currently not supported.
>>
>> There is no special setting for the 2.5V mode. This is how it works:
>> there is one voltage pad for the RGMII interface. Either you connect
>> this pad to a 2.5V voltage or you leave it open (well you would
>> connect some decoupling Cs). If you leave it open the internal LDO,
>> which seems to be enabled in any case takes over, supplying 1.5V. then
>> there is a bit in the debug register which can switch the internal LDO
>> to 1.8V. So if you'll use 2.5V the bit is irrelevant.
>>
>> Like I said maybe a "rgmii-io-microvolts" is a better property and
>> only in the 1800000 setting would turn on this bit. but then both
>> other setting would be a noop.
>
> That would align with the regulator subsystem units, but maybe you
> should have the PHY driver be a regulator provider for itself so you
> can
> chose wether you want to operate at 1.5V or 1.8V, or you have an
> external regulator providing I/O supplies. That would make the whole
> thing consistent from the driver's perspective and would not
> necessarily
> be too far fetched from a HW description perspective?
Sounds good. But again, I'm not too familiar with that. Could you give
an
example how the device tree would look like then? Maybe that way I can
work
myself through that regulator stuff.
--
michael
next prev parent reply other threads:[~2019-10-31 17:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 22:42 [RFC PATCH 0/3] net: phy: at803x device tree binding Michael Walle
2019-10-30 22:42 ` [RFC PATCH 1/3] net: phy: at803x: fix Kconfig description Michael Walle
2019-10-30 23:13 ` Andrew Lunn
2019-10-30 23:16 ` Florian Fainelli
2019-10-30 23:18 ` Andrew Lunn
2019-10-30 23:32 ` Florian Fainelli
2019-10-31 0:05 ` Michael Walle
2019-10-30 22:42 ` [RFC PATCH 2/3] dt-bindings: net: phy: Add support for AT803X Michael Walle
2019-10-30 23:17 ` Andrew Lunn
2019-10-31 0:14 ` Michael Walle
2019-10-31 16:45 ` Florian Fainelli
2019-10-31 17:14 ` Michael Walle [this message]
2019-10-30 23:28 ` Florian Fainelli
2019-10-30 23:36 ` Michael Walle
2019-11-01 15:03 ` Simon Horman
2019-11-02 1:19 ` Michael Walle
2019-10-30 22:42 ` [RFC PATCH 3/3] net: phy: at803x: add device tree binding Michael Walle
2019-10-30 23:21 ` Andrew Lunn
2019-10-30 23:28 ` Florian Fainelli
2019-10-30 23:59 ` Michael Walle
2019-10-31 17:22 ` Michael Walle
2019-10-31 17:35 ` Florian Fainelli
2019-11-02 1:18 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68a8bef6f7d5193e7d373311c8045d7@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).