From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F23DCA9ECE for ; Thu, 31 Oct 2019 17:14:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3836C20873 for ; Thu, 31 Oct 2019 17:14:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="EagMqH3W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728839AbfJaROT (ORCPT ); Thu, 31 Oct 2019 13:14:19 -0400 Received: from ssl.serverraum.org ([176.9.125.105]:56589 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728547AbfJaROT (ORCPT ); Thu, 31 Oct 2019 13:14:19 -0400 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 7B49622EE3; Thu, 31 Oct 2019 18:14:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1572542056; bh=H+8psUup3ZCDa9zLbaL2GibnjLdJl/ZYLNn90edDLYo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EagMqH3WE92hn7Nn173jsO1ZzBo0UCnH8fjglgONoeTflWtmWz/SIStEYP/EOodtA keflHhOOzIIxga3jfQPyIwWk3H5m0wX+rDbpcp0PJuqtdXDzLUHUPvNHvFVrRauzv9 PYi7RsbsJ897hu8dpHWzpV9mZzxy7gbnIQewzqig= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 31 Oct 2019 18:14:16 +0100 From: Michael Walle To: Florian Fainelli Cc: Andrew Lunn , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH 2/3] dt-bindings: net: phy: Add support for AT803X In-Reply-To: References: <20191030224251.21578-1-michael@walle.cc> <20191030224251.21578-3-michael@walle.cc> <20191030231706.GG10555@lunn.ch> <9C1BD4CD-DB02-40CA-940E-3F5579BAE5F4@walle.cc> Message-ID: X-Sender: michael@walle.cc User-Agent: Roundcube Webmail/1.2.3 X-Virus-Scanned: clamav-milter 0.101.4 at web X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2019-10-31 17:45, schrieb Florian Fainelli: > On 10/30/19 5:14 PM, Michael Walle wrote: >>> So we can later add atheros,rgmii-io-2v5. That might need a regulator >>> as well. Maybe add that 2.5V is currently not supported. >> >> There is no special setting for the 2.5V mode. This is how it works: >> there is one voltage pad for the RGMII interface. Either you connect >> this pad to a 2.5V voltage or you leave it open (well you would >> connect some decoupling Cs). If you leave it open the internal LDO, >> which seems to be enabled in any case takes over, supplying 1.5V. then >> there is a bit in the debug register which can switch the internal LDO >> to 1.8V. So if you'll use 2.5V the bit is irrelevant. >> >> Like I said maybe a "rgmii-io-microvolts" is a better property and >> only in the 1800000 setting would turn on this bit. but then both >> other setting would be a noop. > > That would align with the regulator subsystem units, but maybe you > should have the PHY driver be a regulator provider for itself so you > can > chose wether you want to operate at 1.5V or 1.8V, or you have an > external regulator providing I/O supplies. That would make the whole > thing consistent from the driver's perspective and would not > necessarily > be too far fetched from a HW description perspective? Sounds good. But again, I'm not too familiar with that. Could you give an example how the device tree would look like then? Maybe that way I can work myself through that regulator stuff. -- michael