From: Pavel Andrianov <andrianov@ispras.ru>
To: Kashyap Desai <kashyap.desai@avagotech.com>
Cc: Sumit Saxena <sumit.saxena@avagotech.com>,
Uday Lingala <uday.lingala@avagotech.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vaishali Thakkar <vaishali.thakkar@oracle.com>,
ldv-project@linuxtesting.org
Subject: A potential race in drivers/scsi/megaraid.ko
Date: Fri, 12 Aug 2016 13:44:18 +0300 [thread overview]
Message-ID: <d68c390c-1794-796d-cdb2-402f1214ca4c@ispras.ru> (raw)
Hi!
There is a potential data race in drivers/scsi/megaraid.ko
Regards such case:
Thread 1 Thread 2
... ...
-> megaraid_probe_one
-> request_irq - now an interrupt may arise
-> mega_query_adapter
-> issue_scb_block
interrupt comes
-> megaraid_isr_iomapped
-> mega_runpendq
-> __mega_runpendq
-> issue_skb
In this case the structure 'mbox' is modified from two threads
simultaneously. Or, more correct, the first modification is interrupted
by the second one. Likely, the first thread should acquire the same
spinlock adapter->lock as the second one.
--
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@ispras.ru
reply other threads:[~2016-08-12 10:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68c390c-1794-796d-cdb2-402f1214ca4c@ispras.ru \
--to=andrianov@ispras.ru \
--cc=jejb@linux.vnet.ibm.com \
--cc=kashyap.desai@avagotech.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
--cc=vaishali.thakkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).