From: Dan Murphy <dmurphy@ti.com>
To: Rob Herring <robh@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: <rpurdie@rpsys.net>, <pavel@ucw.cz>, <linux-leds@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard
Date: Tue, 5 Dec 2017 07:06:22 -0600 [thread overview]
Message-ID: <d68fa3d3-1280-b9ae-bf11-7784a73b1719@ti.com> (raw)
In-Reply-To: <20171204223500.f6ukdorpcmerzwot@rob-hp-laptop>
Rob
On 12/04/2017 04:35 PM, Rob Herring wrote:
> On Sun, Dec 03, 2017 at 02:27:20PM +0100, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 12/01/2017 05:56 PM, Dan Murphy wrote:
>>> Update the lp8860 dt binding to the LED standard where
>>> the LED should have a child node and also adding a
>>> LED trigger entry.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> ---
>>>
>>> v6 - New patch to fix binding documentation
>>>
>>> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----
>>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>>> index aad38dd94d4b..4cf396de6eba 100644
>>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>>> @@ -12,17 +12,24 @@ Required properties:
>>> - label - Used for naming LEDs
>>>
>>> Optional properties:
>>> - - enable-gpio - gpio pin to enable/disable the device.
>>> - - supply - "vled" - LED supply
>>> + - enable-gpios : gpio pin to enable/disable the device.
>>> + - vled-supply : LED supply
>>> + - label : see Documentation/devicetree/bindings/leds/common.txt
>>> + - linux,default-trigger : (optional)
>>> + see Documentation/devicetree/bindings/leds/common.txt
>>>
>>> Example:
>>>
>>> -leds: leds@6 {
>>> +lp8860@2d {
>
> leds@2d
Ack
>
>>> compatible = "ti,lp8860";
>>> reg = <0x2d>;
>>> - label = "display_cluster";
>>> enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>>> vled-supply = <&vbatt>;
>>> +
>>> + backlight: backlight@0 {
>
> unit-address requires a 'reg' property. Building your dts files with W=1
> will tell you this.
I will add this. There is so much noise when enabling this option on the dts
I missed the warning.
Dan
<snip>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2017-12-05 13:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 16:56 [PATCH v6 1/6] leds: Add new API to derive a LED name Dan Murphy
2017-12-01 16:56 ` [PATCH v6 2/6] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Dan Murphy
2017-12-01 16:56 ` [PATCH v6 3/6] leds: lm3692x: Introduce LM3692x dual string driver Dan Murphy
2017-12-01 16:56 ` [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard Dan Murphy
2017-12-03 13:27 ` Jacek Anaszewski
2017-12-04 22:35 ` Rob Herring
2017-12-05 13:06 ` Dan Murphy [this message]
2017-12-03 13:49 ` Jacek Anaszewski
2017-12-03 14:34 ` Jacek Anaszewski
2017-12-01 16:56 ` [PATCH v6 5/6] leds: lp8860: Update the LED label generation Dan Murphy
2017-12-01 16:59 ` Dan Murphy
2017-12-03 14:00 ` Jacek Anaszewski
2017-12-03 13:57 ` Jacek Anaszewski
2017-12-04 13:11 ` Dan Murphy
2017-12-05 19:56 ` Jacek Anaszewski
2017-12-05 19:59 ` Dan Murphy
2017-12-01 16:56 ` [PATCH v6 6/6] leds: as3645a: " Dan Murphy
2017-12-01 16:58 ` Dan Murphy
2017-12-03 13:27 ` [PATCH v6 1/6] leds: Add new API to derive a LED name Jacek Anaszewski
2017-12-04 13:09 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68fa3d3-1280-b9ae-bf11-7784a73b1719@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).