* [PATCH] ata: rb532_cf: remove redundant codes
@ 2021-06-22 11:55 13145886936
2021-06-25 0:49 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: 13145886936 @ 2021-06-22 11:55 UTC (permalink / raw)
To: axboe; +Cc: linux-ide, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
The codes "dev_err(&pdev->dev, "no IRQ resource found\n");" is
redundant because platform_get_irq() already prints an error.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
drivers/ata/pata_rb532_cf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index 303f8c375b3a..2e110aefe59b 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -115,10 +115,8 @@ static int rb532_pata_driver_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "no IRQ resource found\n");
+ if (irq < 0)
return irq;
- }
if (!irq)
return -EINVAL;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: rb532_cf: remove redundant codes
2021-06-22 11:55 [PATCH] ata: rb532_cf: remove redundant codes 13145886936
@ 2021-06-25 0:49 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-06-25 0:49 UTC (permalink / raw)
To: 13145886936; +Cc: linux-ide, linux-kernel, gushengxian
On 6/22/21 5:55 AM, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> The codes "dev_err(&pdev->dev, "no IRQ resource found\n");" is
> redundant because platform_get_irq() already prints an error.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-25 0:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 11:55 [PATCH] ata: rb532_cf: remove redundant codes 13145886936
2021-06-25 0:49 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).