From: Can Guo <cang@codeaurora.org>
To: Bean Huo <huobean@gmail.com>
Cc: daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, asutoshd@codeaurora.org,
stanley.chu@mediatek.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
ALIM AKHTAR <alim.akhtar@samsung.com>,
JinHwan Park <jh.i.park@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Dukhyun Kwon <d_hyun.kwon@samsung.com>,
Keoseong Park <keosung.park@samsung.com>,
Jaemyung Lee <jaemyung.lee@samsung.com>,
Jieon Seol <jieon.seol@samsung.com>
Subject: Re: [PATCH v31 2/4] scsi: ufs: L2P map management for HPB read
Date: Tue, 23 Mar 2021 12:22:28 +0800 [thread overview]
Message-ID: <d6a032261a642a4afed80188ea4772ee@codeaurora.org> (raw)
In-Reply-To: <75df140d2167eadf1089d014f571d711a9aeb6a5.camel@gmail.com>
On 2021-03-22 17:11, Bean Huo wrote:
> On Mon, 2021-03-22 at 15:54 +0900, Daejun Park wrote:
>> + switch (rsp_field->hpb_op) {
>>
>> + case HPB_RSP_REQ_REGION_UPDATE:
>>
>> + if (data_seg_len != DEV_DATA_SEG_LEN)
>>
>> + dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
>>
>> + "%s: data seg length is not
>> same.\n",
>>
>> + __func__);
>>
>> + ufshpb_rsp_req_region_update(hpb, rsp_field);
>>
>> + break;
>>
>> + case HPB_RSP_DEV_RESET:
>>
>> + dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
>>
>> + "UFS device lost HPB information during
>> PM.\n");
>>
>> + break;
>
> Hi Deajun,
> This series looks good to me. Just here I have one question. You didn't
> handle HPB_RSP_DEV_RESET, just a warning. Based on your SS UFS, how to
> handle HPB_RSP_DEV_RESET from the host side? Do you think we shoud
> reset host side HPB entry as well or what else?
>
>
> Bean
Same question here - I am still collecting feedbacks from flash vendors
about
what is recommanded host behavior on reception of HPB Op code 0x2, since
it
is not cleared defined in HPB2.0 specs.
Can Guo.
next prev parent reply other threads:[~2021-03-23 4:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p5>
2021-03-22 6:51 ` [PATCH v31 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p1>
2021-03-22 6:53 ` [PATCH v31 1/4] scsi: ufs: Introduce HPB feature Daejun Park
[not found] ` <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p4>
2021-03-22 6:54 ` [PATCH v31 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-03-22 9:11 ` Bean Huo
2021-03-23 4:22 ` Can Guo [this message]
2021-03-23 4:33 ` Can Guo
[not found] ` <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p6>
2021-03-22 6:55 ` [PATCH v31 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-03-24 5:01 ` Can Guo
[not found] ` <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p7>
2021-03-22 6:54 ` [PATCH v31 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2021-03-23 5:37 ` Re: [PATCH v31 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-03-23 6:07 ` Can Guo
2021-03-23 6:19 ` Daejun Park
2021-03-23 6:26 ` Can Guo
[not found] ` <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p2>
2021-03-23 6:37 ` Daejun Park
2021-03-23 6:47 ` Can Guo
2021-03-23 12:48 ` Avri Altman
2021-03-24 1:45 ` Can Guo
2021-03-24 8:37 ` Bean Huo
2021-03-24 9:24 ` Can Guo
2021-03-24 9:33 ` Bean Huo
2021-03-24 9:37 ` Can Guo
2021-03-25 0:47 ` Re: [PATCH v31 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-03-25 8:12 ` Can Guo
[not found] ` <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p8>
2021-03-26 2:55 ` Daejun Park
2021-03-26 3:15 ` Bart Van Assche
2021-03-22 9:45 ` Re: [PATCH v31 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a032261a642a4afed80188ea4772ee@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=d_hyun.kwon@samsung.com \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=jaemyung.lee@samsung.com \
--cc=javier.gonz@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jh.i.park@samsung.com \
--cc=jieon.seol@samsung.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).