From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843AbcFHASs (ORCPT ); Tue, 7 Jun 2016 20:18:48 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:34699 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbcFHASq (ORCPT ); Tue, 7 Jun 2016 20:18:46 -0400 From: Daniel Bristot de Oliveira X-Google-Original-From: Daniel Bristot de Oliveira Subject: Re: [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint To: Peter Zijlstra , Mathieu Desnoyers References: <1464362168-17064-1-git-send-email-jdesfossez@efficios.com> <1464362168-17064-2-git-send-email-jdesfossez@efficios.com> <1176128471.22690.1464614300448.JavaMail.zimbra@efficios.com> <1276244634.29549.1465242720729.JavaMail.zimbra@efficios.com> <20160606210353.GF30154@twins.programming.kicks-ass.net> Cc: Julien Desfossez , Ingo Molnar , Thomas Gleixner , rostedt , linux-kernel@vger.kernel.org Message-ID: Date: Tue, 7 Jun 2016 21:18:41 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160606210353.GF30154@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 06:03 PM, Peter Zijlstra wrote: >>>> > >> +/* >>>> > >> + * Tracepoint for priority changes of a task. >>>> > >> + */ >>>> > >> +DEFINE_EVENT(sched_prio_template, sched_set_prio, >>>> > >> + TP_PROTO(struct task_struct *tsk, int newprio), >>>> > >> + TP_ARGS(tsk, newprio)); >>>> > >> + > Nak on anything that cannot fundamentally deal with SCHED_DEADLINE. My 2 cents: I liked the idea... But, I agree with peterz. This cannot fundamentally deal with deadline scheduler. In the deadline scheduler, the priority is set at every new sporadic activation of the task (it is a fixed job priority scheduler - not a fixed priority scheduler). The priority is the deadline of the new job. The deadline is an u64, that does not fit in the int prio - so it cannot be reused. -- Daniel