From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932140AbeAXHJ2 (ORCPT ); Wed, 24 Jan 2018 02:09:28 -0500 Received: from mail.kapsi.fi ([91.232.154.25]:41185 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbeAXHJ0 (ORCPT ); Wed, 24 Jan 2018 02:09:26 -0500 Subject: Re: [PATCH-next] drm/tegra: gem: Use PTR_ERR_OR_ZERO To: =?UTF-8?Q?Christopher_D=c3=adaz_Riveros?= , thierry.reding@gmail.com, airlied@linux.ie, jonathanh@nvidia.com Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20180123202922.14334-1-chrisadr@gentoo.org> From: Mikko Perttunen Message-ID: Date: Wed, 24 Jan 2018 09:09:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180123202922.14334-1-chrisadr@gentoo.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 84.248.219.42 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This nas been NAK'd before as harder to read than the current way. Thanks, Mikko On 01/23/2018 10:29 PM, Christopher Díaz Riveros wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Christopher Díaz Riveros > --- > drivers/gpu/drm/tegra/gem.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c > index 49b9bf28f872..36c4ecc33e1a 100644 > --- a/drivers/gpu/drm/tegra/gem.c > +++ b/drivers/gpu/drm/tegra/gem.c > @@ -416,10 +416,7 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm, > > bo = tegra_bo_create_with_handle(file, drm, args->size, 0, > &args->handle); > - if (IS_ERR(bo)) > - return PTR_ERR(bo); > - > - return 0; > + return PTR_ERR_OR_ZERO(bo); > } > > static int tegra_bo_fault(struct vm_fault *vmf) >