From: Joe Perches <joe@perches.com>
To: keosung.park@samsung.com, ALIM AKHTAR <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"satyat@google.com" <satyat@google.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] scsi: ufs: Add indent for code alignment
Date: Wed, 16 Jun 2021 20:35:26 -0700 [thread overview]
Message-ID: <d6c939f27ee67dda21562e4eb1573e6180ecef1c.camel@perches.com> (raw)
In-Reply-To: <2038148563.21623893584364.JavaMail.epsvc@epcpadp4>
On Thu, 2021-06-17 at 10:28 +0900, Keoseong Park wrote:
> > On Thu, 2021-06-10 at 13:07 +0900, Keoseong Park wrote:
> > > Add indentation to return statement.
> > []
> > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > []
> > > @@ -903,7 +903,7 @@ static inline bool
> > > ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
> > > else
> > > return false;
> > > #else
> > > -return true;
> > > + return true;
> > > #endif
> > > }
> > >
> >
> > Perhaps a little refactoring instead:
> > ---
> > drivers/scsi/ufs/ufshcd.h | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > index c98d540ac044d..ed89839476b3b 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -894,15 +894,11 @@ static inline bool
> > ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba *hba)
> > static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
> > {
> > /* DWC UFS Core has the Interrupt aggregation feature but is not
> > detectable*/
> > -#ifndef CONFIG_SCSI_UFS_DWC
> > - if ((hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> > - !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR))
> > + if (IS_ENABLED(CONFIG_SCSI_UFS_DWC))
> > return true;
> > - else
> > - return false;
> > -#else
> > -return true;
> > -#endif
> > +
> > + return (hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> > + !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR);
> > }
> >
> > static inline bool ufshcd_can_aggressive_pc(struct ufs_hba *hba)
> >
>
> Hello Joe,
> Thanks for your advice.
> As you mentioned, refactoring looks good.
> However, since the content does not match the title, can I submit a
> patch with a new title?
Yes of course.
prev parent reply other threads:[~2021-06-17 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210610040731epcms2p7533bc62d13b82a0e86590f30ac4b6c30@epcms2p7>
2021-06-10 4:07 ` [PATCH] scsi: ufs: Add indent for code alignment Keoseong Park
2021-06-10 4:54 ` Joe Perches
[not found] ` <CGME20210610040731epcms2p7533bc62d13b82a0e86590f30ac4b6c30@epcms2p1>
2021-06-17 1:28 ` Keoseong Park
2021-06-17 3:35 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c939f27ee67dda21562e4eb1573e6180ecef1c.camel@perches.com \
--to=joe@perches.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satyat@google.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).