From: Dmitry Osipenko <digetx@gmail.com>
To: "Randy Dunlap" <rdunlap@infradead.org>,
"Jens Axboe" <axboe@kernel.dk>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"David Heidelberg" <david@ixit.cz>,
"Peter Geis" <pgwipeout@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Nicolas Chauvet" <kwizart@gmail.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Billy Laws" <blaws05@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-block@vger.kernel.org,
Andrey Danin <danindrey@mail.ru>,
Gilles Grandou <gilles@grandou.net>,
Ryan Grachek <ryan@edited.us>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/8] partitions: Introduce NVIDIA Tegra Partition Table
Date: Fri, 6 Mar 2020 05:30:39 +0300 [thread overview]
Message-ID: <d6e4a7b1-3412-7ccc-1941-04d28b847698@gmail.com> (raw)
In-Reply-To: <14ebbc7f-91f3-16dd-b998-ddd71385c772@infradead.org>
06.03.2020 05:22, Randy Dunlap пишет:
> On 3/5/20 6:12 PM, Dmitry Osipenko wrote:
>> All NVIDIA Tegra devices use a special partition table format for the
>> internal storage partitioning. Most of Tegra devices have GPT partition
>> in addition to TegraPT, but some older Android consumer-grade devices do
>> not or GPT is placed in a wrong sector, and thus, the TegraPT is needed
>> in order to support these devices properly in the upstream kernel. This
>> patch adds support for NVIDIA Tegra Partition Table format that is used
>> at least by all NVIDIA Tegra20 and Tegra30 devices.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> arch/arm/mach-tegra/tegra.c | 54 ++++
>> block/partitions/Kconfig | 9 +
>> block/partitions/Makefile | 1 +
>> block/partitions/check.c | 4 +
>> block/partitions/tegra.c | 510 ++++++++++++++++++++++++++++++++++
>> block/partitions/tegra.h | 83 ++++++
>> include/soc/tegra/bootdata.h | 46 +++
>> include/soc/tegra/common.h | 9 +
>> include/soc/tegra/partition.h | 18 ++
>> 9 files changed, 734 insertions(+)
>> create mode 100644 block/partitions/tegra.c
>> create mode 100644 block/partitions/tegra.h
>> create mode 100644 include/soc/tegra/bootdata.h
>> create mode 100644 include/soc/tegra/partition.h
>
> Hi Dmitry,
>
>
>> diff --git a/block/partitions/Kconfig b/block/partitions/Kconfig
>> index 702689a628f0..d3c5c6ad6d58 100644
>> --- a/block/partitions/Kconfig
>> +++ b/block/partitions/Kconfig
>> @@ -268,3 +268,12 @@ config CMDLINE_PARTITION
>> help
>> Say Y here if you want to read the partition table from bootargs.
>> The format for the command line is just like mtdparts.
>> +
>> +config TEGRA_PARTITION
>> + bool "NVIDIA Tegra Partition support" if PARTITION_ADVANCED
>> + default y if ARCH_TEGRA
>> + depends on ARCH_TEGRA || COMPILE_TEST
>> + select MMC_BLOCK
>
> You shouldn't select MMC_BLOCK unless MMC is already enabled,
> so this entire config should depend on MMC also.
> As is, without MMC set/enabled, it should give you a kconfig warning.
>
> (no, you should not also select MMC here.)
>
> (This is just based on reading the patch--I haven't tested it
> with CONFIG_MMC not set/enabled. Have you?)
Hello Randy,
I haven't tested it with the disabled CONFIG_MMC, that's a good
suggestion. I'll take it into account in a v3, thank you.
next prev parent reply other threads:[~2020-03-06 2:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 2:12 [PATCH v2 0/8] Introduce NVIDIA Tegra Partition Tablex Dmitry Osipenko
2020-03-06 2:12 ` [PATCH v2 1/8] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko
2020-03-06 2:12 ` [PATCH v2 2/8] mmc: block: Add mmc_bdev_to_card() helper Dmitry Osipenko
2020-03-06 2:12 ` [PATCH v2 3/8] partitions: Introduce NVIDIA Tegra Partition Table Dmitry Osipenko
2020-03-06 2:22 ` Randy Dunlap
2020-03-06 2:30 ` Dmitry Osipenko [this message]
2020-03-08 23:30 ` kbuild test robot
2020-03-06 2:12 ` [PATCH v2 4/8] mmc: block: Add mmc_bdev_to_part_type() helper Dmitry Osipenko
2020-03-06 2:12 ` [PATCH v2 5/8] mmc: block: Add mmc_bdev_to_area_type() helper Dmitry Osipenko
2020-03-06 2:12 ` [PATCH v2 6/8] mmc: block: Add MMC_QUIRK_RESCAN_MAIN_BLKDEV Dmitry Osipenko
2020-03-06 2:12 ` [PATCH v2 7/8] mmc: block: Enable partition-table scanning for boot partitions Dmitry Osipenko
2020-03-06 2:12 ` [PATCH v2 8/8] partitions/tegra: Implement eMMC boot partitions scanning Dmitry Osipenko
2020-03-06 11:00 ` kbuild test robot
2020-03-09 5:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e4a7b1-3412-7ccc-1941-04d28b847698@gmail.com \
--to=digetx@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=blaws05@gmail.com \
--cc=danindrey@mail.ru \
--cc=david@ixit.cz \
--cc=gilles@grandou.net \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pgwipeout@gmail.com \
--cc=rdunlap@infradead.org \
--cc=ryan@edited.us \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).