From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Michael Straube <michael.straube@posteo.de>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition
Date: Fri, 22 Jun 2018 03:54:22 -0700 [thread overview]
Message-ID: <d6f21cd91d4e6482b5c5d125607ed75c25e9c7a0.camel@perches.com> (raw)
In-Reply-To: <20180622104007.ob5nt2rip2fu436h@mwanda>
On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote:
> On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote:
> > Fix checkpatch error 'do not use assignment in if condition'.
[]
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > index e55895632921..87a4ced41028 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > +++ b/
> > @@ -1181,9 +1181,8 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)
> > (mac[3] == 0xff) && (mac[4] == 0xff) && (mac[5] == 0xff)) ||
> > ((mac[0] == 0x00) && (mac[1] == 0x00) && (mac[2] == 0x00) &&
> > (mac[3] == 0x00) && (mac[4] == 0x00) && (mac[5] == 0x00))) {
Should also use is_broadcast_ether_addr and is_zero_ether_addr
> > - if (np &&
> > - (addr = of_get_property(np, "local-mac-address", &len)) &&
> > - len == ETH_ALEN) {
> > + addr = of_get_property(np, "local-mac-address", &len);
> > + if (np && addr && len == ETH_ALEN) {
>
> You can remove the "np" check.
>
> if (addr && len == ETH_ALEN) {
It looks more like the rewrite is incorrect
as np is tested before of_get_property
It could be written something like:
if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) {
bool assigned = false;
if (np) {
addr = of_get_property(np, "local-mac-address", &len);
if (len == ETH_ALEN) {
memcpy(mac_addr, addr, ETH_ALEN);
assigned = true;
}
}
if (!assigned) {
mac_addr[0] = 0x00;
mac_addr[1] = ...
}
}
next prev parent reply other threads:[~2018-06-22 10:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:22 [PATCH] staging: rtl8723bs: do not use assignment in if condition Michael Straube
2018-06-22 10:40 ` Dan Carpenter
2018-06-22 10:54 ` Joe Perches [this message]
2018-06-22 10:57 ` Dan Carpenter
2018-06-22 12:48 ` Michael Straube
2018-06-22 17:28 ` Joe Perches
2018-06-22 19:11 ` Michael Straube
2018-06-23 1:59 ` Joe Perches
2018-06-25 9:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f21cd91d4e6482b5c5d125607ed75c25e9c7a0.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.straube@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).