From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5809BC61DA4 for ; Thu, 16 Feb 2023 18:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbjBPSeN (ORCPT ); Thu, 16 Feb 2023 13:34:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbjBPSeL (ORCPT ); Thu, 16 Feb 2023 13:34:11 -0500 X-Greylist: delayed 452 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 16 Feb 2023 10:34:09 PST Received: from forward502c.mail.yandex.net (forward502c.mail.yandex.net [IPv6:2a02:6b8:c03:500:1:45:d181:d502]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 920D2EC44 for ; Thu, 16 Feb 2023 10:34:09 -0800 (PST) Received: from iva8-eaa10739bb9b.qloud-c.yandex.net (iva8-eaa10739bb9b.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:c20e:0:640:eaa1:739]) by forward502c.mail.yandex.net (Yandex) with ESMTP id A08895EEB9; Thu, 16 Feb 2023 21:26:31 +0300 (MSK) Received: by iva8-eaa10739bb9b.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id TQqiIlBYp0U1-EKlK2b5X; Thu, 16 Feb 2023 21:26:31 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lach.pw; s=mail; t=1676571991; bh=+N+w4FHvR3Wjef2EHy6zll+1B2G14vAMncJdLdK0Ogo=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=a2Qiv7hwTp5yNYPhWoVpNHATB+bHBOISVtxk28g7FUvcyaQt+oigBh59vSHUgaH+p cH7Ws62eINz0arMvYBeWv8y/fLNIw+7Jvv2DSBI+vx/P6Uc+qBRBKTqVPUOOtY8xsR DC1lha5BJjFVpTPvuUHakryDk+Ga8pLu1ddhQTlQ= Authentication-Results: iva8-eaa10739bb9b.qloud-c.yandex.net; dkim=pass header.i=@lach.pw Message-ID: Date: Thu, 16 Feb 2023 19:26:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] drm/edid: Add Vive Pro 2 to non-desktop list Content-Language: en-US To: Dmitry Osipenko , Jani Nikula , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Thomas Zimmermann References: <20220118170037.14584-1-iam@lach.pw> <5d5a8183-aebc-6660-9cbc-03950f9b14b8@collabora.com> <87v8k5vqg6.fsf@intel.com> <831e7daf-48ae-cea8-a5d2-3786317b3b65@collabora.com> <87sff9vl6j.fsf@intel.com> From: Iaroslav Boliukin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/23 12:50, Dmitry Osipenko wrote: > On 2/13/23 14:50, Jani Nikula wrote: >> On Mon, 13 Feb 2023, Dmitry Osipenko wrote: >>> On 2/13/23 12:56, Jani Nikula wrote: >>>> On Sun, 12 Feb 2023, Dmitry Osipenko wrote: >>>>> Hi, >>>>> >>>>> On 1/18/22 20:00, Yaroslav Bolyukin wrote: >>>>> >>>>> Add a brief commit message, describing a user-visible effect of this >>>>> patch. Tell that this change prevents exposing headset as a regular >>>>> display to the system, while it will work with SteamVR. >>>>> >>>>>> Signed-off-by: Yaroslav Bolyukin >>>>>> --- >>>>>> drivers/gpu/drm/drm_edid.c | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >>>>>> index 12893e7be..fdb8f0a6f 100644 >>>>>> --- a/drivers/gpu/drm/drm_edid.c >>>>>> +++ b/drivers/gpu/drm/drm_edid.c >>>>>> @@ -200,9 +200,10 @@ static const struct edid_quirk { >>>>>> EDID_QUIRK('V', 'L', 'V', 0x91be, EDID_QUIRK_NON_DESKTOP), >>>>>> EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP), >>>>>> >>>>>> - /* HTC Vive and Vive Pro VR Headsets */ >>>>>> + /* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */ >>>>> >>>>> Nit: I'd keep the original comment, or change it to a generic "HTC VR >>>>> Headsets" to prevent further comment changes >>>>> >>>>>> EDID_QUIRK('H', 'V', 'R', 0xaa01, EDID_QUIRK_NON_DESKTOP), >>>>>> EDID_QUIRK('H', 'V', 'R', 0xaa02, EDID_QUIRK_NON_DESKTOP), >>>>>> + EDID_QUIRK('H', 'V', 'R', 0xaa04, EDID_QUIRK_NON_DESKTOP), >>>>>> >>>>>> /* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ >>>>>> EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP), >>>>>> >>>>>> base-commit: 99613159ad749543621da8238acf1a122880144e >>>>> >>>>> Please send the v2 patch with the added EDID for Cosmos VR and the >>>>> addressed comments. Thanks! >>>> >>>> Yeah, we'll need to EDID to check that it doesn't have the Microsoft >>>> VSDB to indicate non-desktop. See 2869f599c0d8 ("drm/edid: support >>>> Microsoft extension for HMDs and specialized monitors"). >>> >>> Do you mean to skip using the EDID_QUIRK_NON_DESKTOP if MS VSDB entry >>> presents in the EDID? >>> >>> These HTC EDIDs don't have MS VSDB, otherwise the quirk wouldn't be needed. >> >> Okay, I didn't know that. I just observed that the original patch was >> sent before the the MS VSDB parsing was added. > > This will be good to mention in the v2 commit message. > This headset does support some kind of HMD signalling, however, this is not a microsoft-specific extension (0xca125c) but part of the DisplayId spec, "Display Product Primary Use Case" field is set to "7". The problem is, I have no idea what spec I should refer to, as I can't find this errata in the original spec, and the only reference to this value I see is in https://git.linuxtv.org/edid-decode.git utility: https://git.linuxtv.org/edid-decode.git/tree/parse-displayid-block.cpp?ref=aa956e0dd5fb85271dde900ea1ebdda795af7f8b#n1676 I would like to implement this feature, but I need some spec reference.