linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Subject: Re: Regulator probe on demand (or circular dependencies)
Date: Mon, 9 Dec 2019 17:03:38 +0000	[thread overview]
Message-ID: <d7003d64-e838-9dcb-8c61-d6567ff6eb69@ideasonboard.com> (raw)
In-Reply-To: <20191209163755.GF5483@sirena.org.uk>

Hi Mark,

Thanks for getting back to me,

On 09/12/2019 16:37, Mark Brown wrote:
> On Fri, Dec 06, 2019 at 04:38:04PM +0000, Kieran Bingham wrote:
> 
>> The MAX9286 also exposes 2 GPIO pins, as such I have configured the
>> MAX9286 driver [1] to expose a gpio-chip [2].
> 
> So this seems like a MFD then?  The nice thing about using the MFD
> subsystem is that it means that the drivers for the various subsystems
> on the device can instantiate in any order and defer separately without
> interfering with each other which seems like it's the issue here.

Well that's part of the problem... the V4L2 async framework can not
currently support the device performing a probe-defer at all, so it
*will* fail later (and crash currently).

I hope we can fix this sometime - but it's a recurring pain point it
seems. Unless it's just our video-capture driver, I'll have to dig
deeper here, and check with Niklas.


>>  - is there anything I can do here within regulator_dev_lookup() to
>>    attempt creating the regulator_dev 'on-demand' when
>>    of_find_regulator_by_node(node) returns empty? (or is that crazy, and
>>    just a rabbit-hole?)
> 
> This seems like a terrible idea, you'll have a half baked regulator in
> the system which will need special casing all over the place and
> doubtless be an ongoing source of bugs.

Thanks - that's essentially what I'm glad to hear /before/ going down
some rabbit hole. I'll re-evaluate with the team, and see what the next
best steps are.

-- 
Regards
--
Kieran

  reply	other threads:[~2019-12-09 17:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 16:38 Regulator probe on demand (or circular dependencies) Kieran Bingham
2019-12-09 16:37 ` Mark Brown
2019-12-09 17:03   ` Kieran Bingham [this message]
2019-12-09 17:13     ` Mark Brown
2019-12-09 17:16     ` Niklas Söderlund
2019-12-11 22:42   ` Kieran Bingham
2019-12-12 15:56     ` Mark Brown
2019-12-12 16:18       ` Geert Uytterhoeven
2019-12-12 16:49         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7003d64-e838-9dcb-8c61-d6567ff6eb69@ideasonboard.com \
    --to=kieran.bingham@ideasonboard.com \
    --cc=broonie@kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).