From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4 3/4] perf stat: Support 'percore' event qualifier
Date: Tue, 16 Apr 2019 08:31:00 +0800 [thread overview]
Message-ID: <d7141fd1-ea29-e6fc-6738-798c46b99d6b@linux.intel.com> (raw)
In-Reply-To: <20190415192623.GD11294@kernel.org>
On 4/16/2019 3:26 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 15, 2019 at 08:09:09PM +0530, Ravi Bangoria escreveu:
>>
>>
>> On 4/12/19 7:29 PM, Jin Yao wrote:
>>> diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
>>> index 39c05f8..1e312c2 100644
>>> --- a/tools/perf/Documentation/perf-stat.txt
>>> +++ b/tools/perf/Documentation/perf-stat.txt
>>> @@ -43,6 +43,10 @@ report::
>>> param1 and param2 are defined as formats for the PMU in
>>> /sys/bus/event_source/devices/<pmu>/format/*
>>>
>>> + 'percore' is a event qualifier that sums up the event counts for both
>>> + hardware threads in a core.
>>
>> s/both/all/ :
>>
>> $ lscpu | grep Thread
>> Thread(s) per core: 4
>>
>>
>> Apart from that, for the series:
>> Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
>
> Yeah I had fixed up that already, fixed up the patch description this
> time around, "both" was being used there as well, changed to "all".
>
> Thanks, added your Tested-by tag, appreciated.
>
> - Arnaldo
>
Thanks Ravi, Thanks Arnaldo!
next prev parent reply other threads:[~2019-04-16 0:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 13:59 [PATCH v4 0/4] perf: Support a new 'percore' event qualifier Jin Yao
2019-04-12 13:59 ` [PATCH v4 1/4] perf: Add a " Jin Yao
2019-05-18 9:35 ` [tip:perf/core] perf tools: " tip-bot for Jin Yao
2019-04-12 13:59 ` [PATCH v4 2/4] perf stat: Factor out aggregate counts printing Jin Yao
2019-05-18 9:36 ` [tip:perf/core] " tip-bot for Jin Yao
2019-04-12 13:59 ` [PATCH v4 3/4] perf stat: Support 'percore' event qualifier Jin Yao
2019-04-15 14:39 ` Ravi Bangoria
2019-04-15 19:26 ` Arnaldo Carvalho de Melo
2019-04-16 0:31 ` Jin, Yao [this message]
2019-05-18 9:36 ` [tip:perf/core] " tip-bot for Jin Yao
2019-04-12 13:59 ` [PATCH v4 4/4] perf test: Add a simple test for term 'percore' Jin Yao
2019-04-15 8:51 ` [PATCH v4 0/4] perf: Support a new 'percore' event qualifier Jiri Olsa
2019-05-15 19:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7141fd1-ea29-e6fc-6738-798c46b99d6b@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).