From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH] stmmac: Add support for SIMATIC IOT2000 platform
Date: Tue, 25 Apr 2017 11:00:47 +0200 [thread overview]
Message-ID: <d7216317-e749-1347-972f-28dfe57038c0@siemens.com> (raw)
In-Reply-To: <CAHp75VcTzBL4D6nobfDAPQOfEEp-RzBp4BANKYDSaaEtGCyj9A@mail.gmail.com>
On 2017-04-25 09:30, Andy Shevchenko wrote:
> On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2017-04-24 23:27, Andy Shevchenko wrote:
>>> On Mon, Apr 24, 2017 at 10:27 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> The IOT2000 is industrial controller platform, derived from the Intel
>>>> Galileo Gen2 board. The variant IOT2020 comes with one LAN port, the
>>>> IOT2040 has two of them. They can be told apart based on the board asset
>>>> tag in the DMI table.
>
>>>> + const char *asset_tag;
>>>
>>> I guess this is redundant. See below.
>>>
>>>> + {
>>>> + .name = "SIMATIC IOT2000",
>>>> + .asset_tag = "6ES7647-0AA00-0YA2",
>>>> + .func = 6,
>>>> + .phy_addr = 1,
>>>> + },
>>>
>>> The below has same definition disregard on asset_tag.
>>>
>>
>> There is a small difference in the asset tag, just not at the last digit
>> where one may expect it, look:
>>
>> ...-0YA2 -> IOT2020
>> ...-1YA2 -> IOT2040
>
> Yes. And how does it change my statement? You may use one record here
> instead of two.
How? Please be more verbose in your comments.
>
>>
>>>> + {
>>>> + .name = "SIMATIC IOT2000",
>>>> + .asset_tag = "6ES7647-0AA00-1YA2",
>>>> + .func = 6,
>>>> + .phy_addr = 1,
>>>> + },
>
>>>> + {
>>>> + .name = "SIMATIC IOT2000",
>>>> + .asset_tag = "6ES7647-0AA00-1YA2",
>>>> + .func = 7,
>>>> + .phy_addr = 1,
>>>> + },
>>>
>>> How this supposed to work if phy_addr is the same?
>> That address space is MAC-local, and we have two different MACs here.
>
> Got it, though asset_tag here is redundant as well.
>
It's not as it is the only differentiating criteria to tell the
two-ports variant apart from the one-port (and to avoid confusing it
with any potential future variant). We could leave out the name, but I
kept it for documentation purposes.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-04-25 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 19:27 [PATCH] stmmac: Add support for SIMATIC IOT2000 platform Jan Kiszka
2017-04-24 21:27 ` Andy Shevchenko
2017-04-25 5:44 ` Jan Kiszka
2017-04-25 7:30 ` Andy Shevchenko
2017-04-25 9:00 ` Jan Kiszka [this message]
2017-04-25 9:46 ` Andy Shevchenko
2017-04-25 10:07 ` Jan Kiszka
2017-04-25 10:09 ` Jan Kiszka
2017-04-25 11:42 ` Andy Shevchenko
2017-04-25 12:15 ` Jan Kiszka
2017-04-26 18:29 ` Andy Shevchenko
2017-04-25 11:40 ` Andy Shevchenko
2017-04-28 16:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7216317-e749-1347-972f-28dfe57038c0@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sascha.weisenberger@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).