From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755930AbcL0XEd (ORCPT ); Tue, 27 Dec 2016 18:04:33 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:43604 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878AbcL0XEZ (ORCPT ); Tue, 27 Dec 2016 18:04:25 -0500 X-AuditID: b6c32a39-f79256d000001a75-b9-5862f34ed99b Subject: Re: [RFC PATCH 5/6] Documentation: pci: add the exynos5433-pcie binding To: Krzysztof Kozlowski Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org, javier@osg.samsung.com, kishon@ti.com, will.deacon@arm.com, catalin.marinas@arm.com, cpgs@samsung.com From: Jaehoon Chung Message-id: Date: Wed, 28 Dec 2016 08:03:41 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <20161227161916.nb6yf3n2kmkzkeg2@kozik-lap> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfWwLcRjH87trrx0qpxt+JqxORLZo9U6rP2MLIVQMiyW2TJiznXasvem1 Yv4QJLOhDEOWzcvCzDLLrN3YTLzVokZ08xLztpHMUIzY5iXE4tqbZP99nt/zffL9fZ88Slzd QEQrs+1OzmFncyhihOzy7ViddkX/hjT9q2YdqthtRV8r3QAFfbHodEtAjj731mCoqPsTjtp7 3ARqa6tToMfNJwj04JSfQCVt1zF0ruMhhvKvtShQ8Ntd2fzR5ppTNcBc7nWZvdV7CXNDUafC fLChGpj9zxoxc793crIinZtn5dgszqHh7Jl8VrbdkkAtS8lYmGGcrae19BxkojR21sYlUIuS krWLs3PED1OarWyOS3xKZgWBmpk4z8G7nJzGygvOBGoNTTM6Wm/SMQyjM8xaG88YRcl6znrz iiW3bMK2vsI+Yic4GrUPRCghaYAPe/oIicfB9q6LIo9QqskmAA+1flRIRQEGT1wNKP5P/Hxb L5Ma5wGsvVEwpOoC0BcsloVUkeQq+PT4ExDiKDIWdvz9KQ+JcLIZgwWBl+EGQc6AjT/8WIhV ZCLsLCkPs4ycBp93v5KHeCy5Gta/DiokzRj4q7grbBBBInjvXmGYcdHgw8CRIY6B9TW9eMgM kkEFzG/5LZopxWIS9N7EpQiLYG//4BBHwo/+hqFoE2H14AtMmt0P4OCAh5AKN4AvLl3AJNUs +PpNFy65jYZfvrvlkoEKFu5RSxIz/B7wyCVeAD+XhwKHVvQVwN5LZ+SHQEzpsEClw0KUDgtR DvBqMI7LFWwWTqBzjTqBtQkuu0WXydu8IHyxcXOawJ1Akg+QSkCNUiU/3ZCmlrNbhTybD0Al TkWpHn0Tn1RZbN52zsFnOFw5nOADRnHJh/HosZm8eP92ZwZtmE0bGANNmxg9Q41Xnd01N01N Wlgnt5njcjnH/zlMGRG9E0zxbEpaHj9DQ70Hlef+POl4n0BP52srA9p4Pb+uape16PKWhXmd A3tad9Tt8/SY7tcy67VLZ5Z2x+TzR94UH7ufsmRdRSIYjx9Ai+M2YiM9Pv/2+t1l19d4V6ZX lcjPtrTuSD1Z1U6//WNPub3R9M5omJpa1vfY3TPqbkXELUOhipIJVpaOwx0C+w+qNLW9xwMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t9jAV2/z0kRBhcuslksacqweL+sh9Hi 5SFNi/lHzrFavHm7hsmi//FrZosLT3vYLM6f38BucXnXHDaLs/OOs1nMOL+PyWLp9YtMFq17 j7BbvPx4gsWBz2PNvDWMHgs2lXpsWtXJ5rGl/y67R9+WVYwex29sZ/L4vEkugD3KzSYjNTEl tUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhkH dqYXzJas+NTxia2BcYpIFyMnh4SAicT3J5tZIGwxiQv31rN1MXJxCAksZZQ4+m4tM4TzgFHi 5KxN7CBVwgIBElOu3mIGsUUENCWu//3OClH0nlHi1cZOsA5mgV1MEkcnvGYCqWIT0JHY/u04 mM0rYCdxd8YCMJtFQFXi5uM7QN0cHKICYRLPG50gSgQlfky+B3YSp4CFxKlTHSwgJcwC6hJT puSChJkF5CU2r3nLPIFRYBaSjlkIVbOQVC1gZF7FKJFakFxQnJSea5iXWq5XnJhbXJqXrpec n7uJERy1z6R2MB7c5X6IUYCDUYmHd8WNpAgh1sSy4srcQ4wSHMxKIryXPgKFeFMSK6tSi/Lj i0pzUosPMZoCfTGRWUo0OR+YUPJK4g1NzE3MjQ0szC0tTYyUxHkbZz8LFxJITyxJzU5NLUgt gulj4uCUamB0qBIN+sXt8pfV/Uzz66AlVbcn/3uyfd+d0xonddXeNfsuLJGYsCh9Wsy1nAmt d2y7rDRK617vkbk812qL1tyOPE27HwrcSxZeDX2UJqKkbe71rrH26Wpl9fy3qZYrF6dcNg4O ei+6Ru/DY17/WNM/r2Ytv/VHbUJrmdxDo91RghJ6N5XdT8QosRRnJBpqMRcVJwIA7TGc+PAC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161227230342epcas1p219b8f561621b45ce7a9926c056d3ee68 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161226052031epcas5p4f151c41189f7b3811979ca1e10aab1be X-RootMTR: 20161226052031epcas5p4f151c41189f7b3811979ca1e10aab1be References: <20161226052029.10552-1-jh80.chung@samsung.com> <20161226052029.10552-6-jh80.chung@samsung.com> <20161227161916.nb6yf3n2kmkzkeg2@kozik-lap> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/28/2016 01:19 AM, Krzysztof Kozlowski wrote: > On Mon, Dec 26, 2016 at 02:20:28PM +0900, Jaehoon Chung wrote: >> Signed-off-by: Jaehoon Chung >> --- >> .../devicetree/bindings/pci/exynos5433-pcie.txt | 36 ++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/exynos5433-pcie.txt >> >> diff --git a/Documentation/devicetree/bindings/pci/exynos5433-pcie.txt b/Documentation/devicetree/bindings/pci/exynos5433-pcie.txt >> new file mode 100644 >> index 0000000..932a847 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/exynos5433-pcie.txt >> @@ -0,0 +1,36 @@ >> +* Samsung Exynos5433 PCIe interface >> + >> +This PCIe host controller is based on the Synopsis Designware PCIe IP > > Synopsys. Will fix. > >> +and thus inherits all the common properties defined in designware-pcie.txt. >> + >> +Required properties: >> +- compatible: "samsung,exynos5433-pcie" >> +- reg: base addresses and lengths of the pcie controller, >> + the phy controller, additional register for the phy controller. > > You mentioned three regs but the example contains four of them. Is the > config comming from snps,dw-pcie? Oops..It's my mistake. Just needs to put three reg. Elbi : External local Bus interface register. Dbi : Data bus interface register.(Control register.) Config : for configuration space. "config" can be removed. Because it's not Exynos specific, synopsys's Required property. > >> +- reg-names: Must be "elbi", "phy" and "dbi" for each regs > > Again, three here, four in example. Will fix. > >> +- interrupt-names: Must be "intr" for legacy interrupt pin. >> + >> +Other common properites refer to >> + Documentation/devicetree/binding/pci/designware-pcie.txt >> + >> +Example: >> + >> + pcie: pcie@15700000 { >> + compatible ="samsung,exynos5433-pcie", "snps,dw-pcie"; > ^ > space needed >> + #address-cells = <3>; >> + #size-cells = <2>; >> + device_type = "pci"; >> + interrupts = ; >> + interrupt-names = "intr"; >> + clocks = <&cmu_fsys CLK_PCIE>, <&cmu_fsys CLK_PCLK_PCIE_PHY>; >> + clock-names = "pcie", "pcie_bus"; >> + num-lanes = <1>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pcie_bus>; >> + reg = <0x156b0000 0x1000>, <0x15680000 0x1000>, >> + <0x15700000 0x1000>, <0x0c000000 0x1000>; > > Indentation here looks wrong. You indented it with spaces after tabs... > but not to align with line before. Will fix. Best Regards, Jaehoon Chung > > Beside that, fine with me: > Acked-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > > >> + reg-names = "elbi", "phy", "dbi", "config"; >> + ranges = <0x81000000 0 0 0x0c001000 0 0x00010000 >> + 0x82000000 0 0x0c011000 0x0c011000 0 0x3feefff>; >> + status = "disabled"; >> + }; >> -- >> 2.10.2 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >