From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934600AbcKMM2y (ORCPT ); Sun, 13 Nov 2016 07:28:54 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:40542 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933584AbcKMM2w (ORCPT ); Sun, 13 Nov 2016 07:28:52 -0500 Subject: Re: [PATCH v4 21/26] staging: iio: tsl2583: clarified comment about clearing interrupts To: Brian Masney , linux-iio@vger.kernel.org References: <1478974781-1457-1-git-send-email-masneyb@onstation.org> <1478974781-1457-22-git-send-email-masneyb@onstation.org> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com From: Jonathan Cameron Message-ID: Date: Sun, 13 Nov 2016 12:28:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478974781-1457-22-git-send-email-masneyb@onstation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/16 18:19, Brian Masney wrote: > The comment that describes the code that clears the interrupt bit was > vague and didn't provide much value. This patch adds more detail about > why that bit needs to be cleared. > > Signed-off-by: Brian Masney Applied. > --- > drivers/staging/iio/light/tsl2583.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c > index 806cb0a..727ed49 100644 > --- a/drivers/staging/iio/light/tsl2583.c > +++ b/drivers/staging/iio/light/tsl2583.c > @@ -205,8 +205,9 @@ static int tsl2583_get_lux(struct iio_dev *indio_dev) > } > > /* > - * clear status, really interrupt status (interrupts are off), but > - * we use the bit anyway - don't forget 0x80 - this is a command > + * Clear the pending interrupt status bit on the chip to allow the next > + * integration cycle to start. This has to be done even though this > + * driver currently does not support interrupts. > */ > ret = i2c_smbus_write_byte(chip->client, > (TSL2583_CMD_REG | TSL2583_CMD_SPL_FN | >