* [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL
@ 2021-05-26 7:50 Geert Uytterhoeven
2021-05-27 11:07 ` Enric Balletbo i Serra
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-05-26 7:50 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Hsin-Yi Wang, Nicolas Boichat, Enric Balletbo i Serra
Cc: dri-devel, linux-kernel, Geert Uytterhoeven
The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded
Controller, and is accessed using I2C tunneling through the Embedded
Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent
asking the user about this driver when configuring a kernel without
support for the ChromeOS EC tunnel I2C bus.
Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033
config DRM_CROS_EC_ANX7688
tristate "ChromeOS EC ANX7688 bridge"
depends on OF
+ depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST
select DRM_KMS_HELPER
select REGMAP_I2C
help
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL
2021-05-26 7:50 [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL Geert Uytterhoeven
@ 2021-05-27 11:07 ` Enric Balletbo i Serra
2021-05-27 12:10 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2021-05-27 11:07 UTC (permalink / raw)
To: Geert Uytterhoeven, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Hsin-Yi Wang, Nicolas Boichat
Cc: dri-devel, linux-kernel
Hi Geert,
Thank you for your patch.
On 26/5/21 9:50, Geert Uytterhoeven wrote:
> The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded
> Controller, and is accessed using I2C tunneling through the Embedded
> Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent
> asking the user about this driver when configuring a kernel without
> support for the ChromeOS EC tunnel I2C bus.
>
> Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033
> config DRM_CROS_EC_ANX7688
> tristate "ChromeOS EC ANX7688 bridge"
> depends on OF
> + depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST
> select DRM_KMS_HELPER
> select REGMAP_I2C
> help
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL
2021-05-27 11:07 ` Enric Balletbo i Serra
@ 2021-05-27 12:10 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2021-05-27 12:10 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Geert Uytterhoeven, Andrzej Hajda, Neil Armstrong,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Hsin-Yi Wang, Nicolas Boichat, dri-devel,
linux-kernel
Pushed to drm-misc-next.
On Thu, 27 May 2021 at 13:07, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Geert,
>
> Thank you for your patch.
>
> On 26/5/21 9:50, Geert Uytterhoeven wrote:
> > The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded
> > Controller, and is accessed using I2C tunneling through the Embedded
> > Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent
> > asking the user about this driver when configuring a kernel without
> > support for the ChromeOS EC tunnel I2C bus.
> >
> > Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> > ---
> > drivers/gpu/drm/bridge/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033
> > config DRM_CROS_EC_ANX7688
> > tristate "ChromeOS EC ANX7688 bridge"
> > depends on OF
> > + depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST
> > select DRM_KMS_HELPER
> > select REGMAP_I2C
> > help
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-27 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 7:50 [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL Geert Uytterhoeven
2021-05-27 11:07 ` Enric Balletbo i Serra
2021-05-27 12:10 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).