From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8ABC4708A for ; Thu, 27 May 2021 11:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E9B1613D3 for ; Thu, 27 May 2021 11:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233702AbhE0LIu (ORCPT ); Thu, 27 May 2021 07:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232381AbhE0LIs (ORCPT ); Thu, 27 May 2021 07:08:48 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E78D8C061574 for ; Thu, 27 May 2021 04:07:13 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 7B8E61F439AF Subject: Re: [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL To: Geert Uytterhoeven , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Hsin-Yi Wang , Nicolas Boichat Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: From: Enric Balletbo i Serra Message-ID: Date: Thu, 27 May 2021 13:07:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for your patch. On 26/5/21 9:50, Geert Uytterhoeven wrote: > The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded > Controller, and is accessed using I2C tunneling through the Embedded > Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent > asking the user about this driver when configuring a kernel without > support for the ChromeOS EC tunnel I2C bus. > > Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Enric Balletbo i Serra > --- > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033 > config DRM_CROS_EC_ANX7688 > tristate "ChromeOS EC ANX7688 bridge" > depends on OF > + depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST > select DRM_KMS_HELPER > select REGMAP_I2C > help >