* [PATCH] powerpc: net: bpf_jit_comp: Fix misuse of fallthrough
@ 2020-09-28 9:00 zhe.he
2020-09-29 14:41 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: zhe.he @ 2020-09-28 9:00 UTC (permalink / raw)
To: gustavo, netdev, bpf, linuxppc-dev, linux-kernel, zhe.he
From: He Zhe <zhe.he@windriver.com>
The user defined label following "fallthrough" is not considered by GCC
and causes build failure.
kernel-source/include/linux/compiler_attributes.h:208:41: error: attribute
'fallthrough' not preceding a case label or default label [-Werror]
208 define fallthrough _attribute((fallthrough_))
^~~~~~~~~~~~~
Signed-off-by: He Zhe <zhe.he@windriver.com>
---
arch/powerpc/net/bpf_jit_comp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c
index 78d61f97371e..e809cb5a1631 100644
--- a/arch/powerpc/net/bpf_jit_comp.c
+++ b/arch/powerpc/net/bpf_jit_comp.c
@@ -475,7 +475,6 @@ static int bpf_jit_build_body(struct bpf_prog *fp, u32 *image,
case BPF_JMP | BPF_JSET | BPF_K:
case BPF_JMP | BPF_JSET | BPF_X:
true_cond = COND_NE;
- fallthrough;
cond_branch:
/* same targets, can avoid doing the test :) */
if (filter[i].jt == filter[i].jf) {
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: net: bpf_jit_comp: Fix misuse of fallthrough
2020-09-28 9:00 [PATCH] powerpc: net: bpf_jit_comp: Fix misuse of fallthrough zhe.he
@ 2020-09-29 14:41 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2020-09-29 14:41 UTC (permalink / raw)
To: zhe.he, gustavo, netdev, bpf, linuxppc-dev, linux-kernel
On 9/28/20 11:00 AM, zhe.he@windriver.com wrote:
> From: He Zhe <zhe.he@windriver.com>
>
> The user defined label following "fallthrough" is not considered by GCC
> and causes build failure.
>
> kernel-source/include/linux/compiler_attributes.h:208:41: error: attribute
> 'fallthrough' not preceding a case label or default label [-Werror]
> 208 define fallthrough _attribute((fallthrough_))
> ^~~~~~~~~~~~~
>
> Signed-off-by: He Zhe <zhe.he@windriver.com>
Applied, thanks! I've also added Fixes tag with df561f6688fe ("treewide: Use fallthrough pseudo-keyword")
which added the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-29 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 9:00 [PATCH] powerpc: net: bpf_jit_comp: Fix misuse of fallthrough zhe.he
2020-09-29 14:41 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).