linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bus: fsl-mc: properly empty-initialize structure
@ 2019-12-04 14:29 Ioana Ciornei
  2019-12-04 15:01 ` Laurentiu Tudor
  0 siblings, 1 reply; 2+ messages in thread
From: Ioana Ciornei @ 2019-12-04 14:29 UTC (permalink / raw)
  To: gregkh; +Cc: laurentiu.tudor, linux-kernel, Ioana Ciornei

Use the proper form of the empty initializer when working with
structures that contain an array. Otherwise, older gcc versions (eg gcc
4.9) will complain about this.

Fixes: 1ac210d128ef ("bus: fsl-mc: add the fsl_mc_get_endpoint function")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index a07cc19becdb..c78d10ea641f 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -715,9 +715,9 @@ EXPORT_SYMBOL_GPL(fsl_mc_device_remove);
 struct fsl_mc_device *fsl_mc_get_endpoint(struct fsl_mc_device *mc_dev)
 {
 	struct fsl_mc_device *mc_bus_dev, *endpoint;
-	struct fsl_mc_obj_desc endpoint_desc = { 0 };
-	struct dprc_endpoint endpoint1 = { 0 };
-	struct dprc_endpoint endpoint2 = { 0 };
+	struct fsl_mc_obj_desc endpoint_desc = {{ 0 }};
+	struct dprc_endpoint endpoint1 = {{ 0 }};
+	struct dprc_endpoint endpoint2 = {{ 0 }};
 	int state, err;
 
 	mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bus: fsl-mc: properly empty-initialize structure
  2019-12-04 14:29 [PATCH] bus: fsl-mc: properly empty-initialize structure Ioana Ciornei
@ 2019-12-04 15:01 ` Laurentiu Tudor
  0 siblings, 0 replies; 2+ messages in thread
From: Laurentiu Tudor @ 2019-12-04 15:01 UTC (permalink / raw)
  To: Ioana Ciornei, gregkh; +Cc: linux-kernel



On 04.12.2019 16:29, Ioana Ciornei wrote:
> Use the proper form of the empty initializer when working with
> structures that contain an array. Otherwise, older gcc versions (eg gcc
> 4.9) will complain about this.
> 
> Fixes: 1ac210d128ef ("bus: fsl-mc: add the fsl_mc_get_endpoint function")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Thanks,

Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

---
Best Regards, Laurentiu

> ---
>   drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
> index a07cc19becdb..c78d10ea641f 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -715,9 +715,9 @@ EXPORT_SYMBOL_GPL(fsl_mc_device_remove);
>   struct fsl_mc_device *fsl_mc_get_endpoint(struct fsl_mc_device *mc_dev)
>   {
>   	struct fsl_mc_device *mc_bus_dev, *endpoint;
> -	struct fsl_mc_obj_desc endpoint_desc = { 0 };
> -	struct dprc_endpoint endpoint1 = { 0 };
> -	struct dprc_endpoint endpoint2 = { 0 };
> +	struct fsl_mc_obj_desc endpoint_desc = {{ 0 }};
> +	struct dprc_endpoint endpoint1 = {{ 0 }};
> +	struct dprc_endpoint endpoint2 = {{ 0 }};
>   	int state, err;
>   
>   	mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent);
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-04 15:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 14:29 [PATCH] bus: fsl-mc: properly empty-initialize structure Ioana Ciornei
2019-12-04 15:01 ` Laurentiu Tudor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).