From: Randy Dunlap <rdunlap@infradead.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Bjørn Forsman" <bjorn.forsman@gmail.com>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH v3] kbuild: check for pkg-config on make {menu,n,g.x}config
Date: Tue, 5 Jun 2018 17:41:51 -0700 [thread overview]
Message-ID: <d74293e3-02a2-b5fc-4f69-9e6924726278@infradead.org> (raw)
In-Reply-To: <CAK7LNASN_L0An5OBwif7S4wt5Lz54yAdSNw_8ODV0UETa+aDjw@mail.gmail.com>
On 06/04/2018 11:53 PM, Masahiro Yamada wrote:
> Hi Randy,
>
>
> 2018-06-04 11:59 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Each of 'make {menu,n,g,x}config' uses (needs) pkg-config to make sure
>> that other required files are present and to determine build flags
>> settings, but none of these check that pkg-config itself is present.
>> Add a check for all 4 of these targets and update
>> Documentation/process/changes.rst to mention 'pkg-config'.
>>
>> Fixes kernel bugzilla #77511:
>> https://bugzilla.kernel.org/show_bug.cgi?id=77511
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Bjørn Forsman <bjorn.forsman@gmail.com>
>> ---
>> Strictly speaking, pkg-config is not required if someone is only
>> using 'make {menu,n}config' since there are fallbacks for those
>> two targets.
>>
OK, I made your suggested changes and will test it later and then resend it.
thanks,
--
~Randy
prev parent reply other threads:[~2018-06-06 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 2:59 [PATCH v3] kbuild: check for pkg-config on make {menu,n,g.x}config Randy Dunlap
2018-06-05 6:53 ` Masahiro Yamada
2018-06-06 0:41 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d74293e3-02a2-b5fc-4f69-9e6924726278@infradead.org \
--to=rdunlap@infradead.org \
--cc=bjorn.forsman@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).