From: Adrian Hunter <adrian.hunter@intel.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
linux-kernel@vger.kernel.org, Hu Ziji <huziji@marvell.com>,
Zhoujie Wu <zjwu@marvell.com>
Cc: phil@raspberrypi.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com,
stefan.wahren@i2se.com, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 06/11] mmc: sdhci: xenon: Use sdhci_set_power_and_voltage()
Date: Mon, 9 Mar 2020 13:56:58 +0200 [thread overview]
Message-ID: <d75a2a63-a657-6584-5ce2-c2e5550ccf39@intel.com> (raw)
In-Reply-To: <eb9cc6e8-0f15-a609-9f99-c8677eb3354f@intel.com>
+ Zhoujie Wu <zjwu@marvell.com>
On 9/03/20 1:55 pm, Adrian Hunter wrote:
> On 9/03/20 12:53 pm, Nicolas Saenz Julienne wrote:
>> On Mon, 2020-03-09 at 09:20 +0200, Adrian Hunter wrote:
>>>> -static void xenon_set_power(struct sdhci_host *host, unsigned char mode,
>>>> - unsigned short vdd)
>>>> -{
>>>> - struct mmc_host *mmc = host->mmc;
>>>> - u8 pwr = host->pwr;
>>>> -
>>>> - sdhci_set_power_noreg(host, mode, vdd);
>>>> -
>>>> - if (host->pwr == pwr)
>>>> - return;
>>>> -
>>>> - if (host->pwr == 0)
>>>> - vdd = 0;
>>>> -
>>>> - if (!IS_ERR(mmc->supply.vmmc))
>>>> - mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
>>>> -}
>>>
>>> This code is different. The commit message should explain why it is
>>> equivalent. Has it been tested?
>>
>> Yes, I should've pointed it out. The rationale behind including sdhci-xenon and
>> sdhci-pxav3 is based on xenon's original commit message (99c14fc360dbb):
>>
>> mmc: sdhci-xenon: add set_power callback
>>
>> Xenon sdh controller requests proper SD bus voltage select
>> bits programmed even with vmmc power supply. Any reserved
>> value(100b-000b) programmed in this field will lead to controller
>> ignore SD bus power bit and keep its value at zero.
>> Add set_power callback to handle this.
>>
>> I can't test it, but it felt to me as the implementation differences are only
>> there as different people wrote the code. Ultimately, I'll be happy to drop
>> them from the series if you feel it's too much of an assumption, I can see how
>> the controllers could react badly to the ordering change. If not I can send a
>> v3 with fixed commit messages.
>
> We can wait a bit and see if anyone provides a Tested-by tag, otherwise
> safer to drop it.
>
next prev parent reply other threads:[~2020-03-09 11:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 17:44 [PATCH v2 00/11] Raspbery Pi 4 vmmc regulator support Nicolas Saenz Julienne
2020-03-06 17:44 ` [PATCH v2 01/11] mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage() Nicolas Saenz Julienne
2020-03-09 7:21 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 02/11] mmc: sdhci: arasan: Use sdhci_set_power_and_voltage() Nicolas Saenz Julienne
2020-03-09 7:22 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 03/11] mmc: sdhci: milbeaut: " Nicolas Saenz Julienne
2020-03-09 7:25 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 04/11] mmc: sdhci: at91: " Nicolas Saenz Julienne
2020-03-09 7:25 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 05/11] mmc: sdhci: pxav3: " Nicolas Saenz Julienne
2020-03-09 7:20 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 06/11] mmc: sdhci: xenon: " Nicolas Saenz Julienne
2020-03-09 7:20 ` Adrian Hunter
2020-03-09 10:53 ` Nicolas Saenz Julienne
2020-03-09 11:55 ` Adrian Hunter
2020-03-09 11:56 ` Adrian Hunter [this message]
2020-03-06 17:44 ` [PATCH v2 07/11] mmc: sdhci: am654: " Nicolas Saenz Julienne
2020-03-09 7:27 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 08/11] mmc: sdhci: Unexport sdhci_set_power_noreg() Nicolas Saenz Julienne
2020-03-06 17:44 ` [PATCH v2 09/11] mmc: sdhci: iproc: Add custom set_power() callback for bcm2711 Nicolas Saenz Julienne
2020-03-09 7:29 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 10/11] ARM: dts: bcm2711: Update expgpio's GPIO labels Nicolas Saenz Julienne
2020-03-27 11:21 ` Nicolas Saenz Julienne
2020-03-06 17:44 ` [PATCH v2 11/11] ARM: dts: bcm2711: Add vmmc regulator in emmc2 Nicolas Saenz Julienne
2020-03-09 20:00 ` Stefan Wahren
2020-03-09 20:01 ` Nicolas Saenz Julienne
2020-03-27 11:22 ` Nicolas Saenz Julienne
2020-03-12 13:08 ` [PATCH v2 00/11] Raspbery Pi 4 vmmc regulator support Ulf Hansson
2020-03-12 13:13 ` Nicolas Saenz Julienne
2020-03-12 14:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75a2a63-a657-6584-5ce2-c2e5550ccf39@intel.com \
--to=adrian.hunter@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=huziji@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
--cc=ulf.hansson@linaro.org \
--cc=zjwu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).