From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <huobean@gmail.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org,
daejun7.park@samsung.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] scsi: ufs: core: Fix a non-constant function argument name
Date: Tue, 28 Sep 2021 15:15:10 -0700 [thread overview]
Message-ID: <d769cc3c-15ea-7c07-eeaa-e938b8d8483f@acm.org> (raw)
In-Reply-To: <20210928214150.779202-3-huobean@gmail.com>
On 9/28/21 2:41 PM, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
> Since commit 568dd9959611 ("scsi: ufs: Rename the second
> ufshcd_probe_hba() argument"), the second ufshcd_probe_hba()
> argument has been changed to init_dev_params.
>
> Fixes: 568dd9959611 ("scsi: ufs: Rename the second ufshcd_probe_hba() argument")
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index debef631c89a..081092418e2d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -225,7 +225,7 @@ static int ufshcd_eh_host_reset_handler(struct scsi_cmnd *cmd);
> static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag);
> static void ufshcd_hba_exit(struct ufs_hba *hba);
> static int ufshcd_clear_ua_wluns(struct ufs_hba *hba);
> -static int ufshcd_probe_hba(struct ufs_hba *hba, bool async);
> +static int ufshcd_probe_hba(struct ufs_hba *hba, bool init_dev_params);
> static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on);
> static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba);
> static inline void ufshcd_add_delay_before_dme_cmd(struct ufs_hba *hba);
What is a "non-constant function argument name"?
Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2021-09-28 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 21:41 [PATCH v2 0/2] Two fixes for UFS Bean Huo
2021-09-28 21:41 ` [PATCH v2 1/2] scsi: ufs: ufshpb: Fix NULL pointer dereference Bean Huo
2021-09-28 21:41 ` [PATCH v2 2/2] scsi: ufs: core: Fix a non-constant function argument name Bean Huo
2021-09-28 22:15 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d769cc3c-15ea-7c07-eeaa-e938b8d8483f@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).