From: Adrian Hunter <adrian.hunter@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Eric Biggers <ebiggers@google.com>,
Raul E Rangel <rrangel@chromium.org>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2 6/6] mmc: sdhci-pci: Remove dead code (rst_n_gpio et al)
Date: Thu, 14 Oct 2021 13:04:03 +0300 [thread overview]
Message-ID: <d76c1c8b-5d6e-f4b4-d43f-24155b76e75b@intel.com> (raw)
In-Reply-To: <20211013201723.52212-7-andriy.shevchenko@linux.intel.com>
On 13/10/2021 23:17, Andy Shevchenko wrote:
> There is no user of this member. Remove the dead code for good.
>
> The removal is dependent on previous removal of cd_gpio, cd_irq.
I got that wrong, I think it is actually dependent on the sdhci_pci_data
removal?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
With above resolved:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci-core.c | 27 ---------------------------
> drivers/mmc/host/sdhci-pci.h | 2 --
> 2 files changed, 29 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index e2b6f60e9f01..6f9877546830 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1915,21 +1915,6 @@ int sdhci_pci_enable_dma(struct sdhci_host *host)
> return 0;
> }
>
> -static void sdhci_pci_gpio_hw_reset(struct sdhci_host *host)
> -{
> - struct sdhci_pci_slot *slot = sdhci_priv(host);
> - int rst_n_gpio = slot->rst_n_gpio;
> -
> - if (!gpio_is_valid(rst_n_gpio))
> - return;
> - gpio_set_value_cansleep(rst_n_gpio, 0);
> - /* For eMMC, minimum is 1us but give it 10us for good measure */
> - udelay(10);
> - gpio_set_value_cansleep(rst_n_gpio, 1);
> - /* For eMMC, minimum is 200us but give it 300us for good measure */
> - usleep_range(300, 1000);
> -}
> -
> static void sdhci_pci_hw_reset(struct sdhci_host *host)
> {
> struct sdhci_pci_slot *slot = sdhci_priv(host);
> @@ -2060,7 +2045,6 @@ static struct sdhci_pci_slot *sdhci_pci_probe_slot(
>
> slot->chip = chip;
> slot->host = host;
> - slot->rst_n_gpio = -EINVAL;
> slot->cd_idx = -1;
>
> host->hw_name = "PCI";
> @@ -2086,17 +2070,6 @@ static struct sdhci_pci_slot *sdhci_pci_probe_slot(
> goto cleanup;
> }
>
> - if (gpio_is_valid(slot->rst_n_gpio)) {
> - if (!devm_gpio_request(&pdev->dev, slot->rst_n_gpio, "eMMC_reset")) {
> - gpio_direction_output(slot->rst_n_gpio, 1);
> - slot->host->mmc->caps |= MMC_CAP_HW_RESET;
> - slot->hw_reset = sdhci_pci_gpio_hw_reset;
> - } else {
> - dev_warn(&pdev->dev, "failed to request rst_n_gpio\n");
> - slot->rst_n_gpio = -EINVAL;
> - }
> - }
> -
> host->mmc->pm_caps = MMC_PM_KEEP_POWER;
> host->mmc->slotno = slotno;
> host->mmc->caps2 |= MMC_CAP2_NO_PRESCAN_POWERUP;
> diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h
> index 8bb3b9c78589..5e3193278ff9 100644
> --- a/drivers/mmc/host/sdhci-pci.h
> +++ b/drivers/mmc/host/sdhci-pci.h
> @@ -157,8 +157,6 @@ struct sdhci_pci_slot {
> struct sdhci_pci_chip *chip;
> struct sdhci_host *host;
>
> - int rst_n_gpio;
> -
> int cd_idx;
> bool cd_override_level;
>
>
prev parent reply other threads:[~2021-10-14 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 20:17 [PATCH v2 0/6] mmc: sdhci-pci: Add some CD GPIO related quirks Andy Shevchenko
2021-10-13 20:17 ` [PATCH v2 1/6] mmc: sdhci-pci: Read card detect from ACPI for Intel Merrifield Andy Shevchenko
2021-10-14 9:54 ` Adrian Hunter
2021-10-14 11:23 ` Ulf Hansson
2021-10-13 20:17 ` [PATCH v2 2/6] mmc: sdhci: Deduplicate sdhci_get_cd_nogpio() Andy Shevchenko
2021-10-14 9:58 ` Adrian Hunter
2021-10-13 20:17 ` [PATCH v2 3/6] mmc: sdhci: Remove unused prototype declaration in the header Andy Shevchenko
2021-10-14 9:59 ` Adrian Hunter
2021-10-13 20:17 ` [PATCH v2 4/6] mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al) Andy Shevchenko
2021-10-14 10:01 ` Adrian Hunter
2021-10-13 20:17 ` [PATCH v2 5/6] mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq " Andy Shevchenko
2021-10-14 10:02 ` Adrian Hunter
2021-10-13 20:17 ` [PATCH v2 6/6] mmc: sdhci-pci: Remove dead code (rst_n_gpio " Andy Shevchenko
2021-10-14 10:04 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d76c1c8b-5d6e-f4b4-d43f-24155b76e75b@intel.com \
--to=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ebiggers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rrangel@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).