From: Jiri Slaby <jslaby@suse.cz>
To: Johan Hovold <johan@kernel.org>
Cc: Gen Zhang <blackgod016574@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c
Date: Wed, 22 May 2019 12:32:37 +0200 [thread overview]
Message-ID: <d775c1ac-e0ff-919b-22d6-8e585149374c@suse.cz> (raw)
In-Reply-To: <20190522102900.GC2200@localhost>
On 22. 05. 19, 12:29, Johan Hovold wrote:
>> Sure, but can class_find_device return NULL in this tty case here?
>
> Yes, it can and will and that's fine, not all ttys have a struct device
> (e.g. ptys).
IOW, the code needs a comment, if anything.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2019-05-22 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 1:40 [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c Gen Zhang
2019-05-22 4:25 ` Jiri Slaby
2019-05-22 8:06 ` Gen Zhang
2019-05-22 8:15 ` Jiri Slaby
2019-05-22 10:29 ` Johan Hovold
2019-05-22 10:32 ` Jiri Slaby [this message]
2019-05-22 11:13 ` Gen Zhang
2019-05-22 11:19 ` Johan Hovold
2019-05-22 11:24 ` Gen Zhang
2019-05-22 11:18 ` Gen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d775c1ac-e0ff-919b-22d6-8e585149374c@suse.cz \
--to=jslaby@suse.cz \
--cc=blackgod016574@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).