From: Paolo Bonzini <pbonzini@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Lai Jiangshan <laijs@linux.alibaba.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sean Christopherson <seanjc@google.com>,
Andi Kleen <ak@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, Josh Poimboeuf <jpoimboe@redhat.com>,
Uros Bizjak <ubizjak@gmail.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
Joerg Roedel <jroedel@suse.de>, Jian Cai <caij2003@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/4] x86/xen/entry: Rename xenpv_exc_nmi to noist_exc_nmi
Date: Fri, 30 Apr 2021 09:15:51 +0200 [thread overview]
Message-ID: <d77ee423-53fc-d552-1ff8-6fdf75e416a7@redhat.com> (raw)
In-Reply-To: <20210428172714.53adac43@gandalf.local.home>
On 28/04/21 23:27, Steven Rostedt wrote:
> On Tue, 27 Apr 2021 07:09:46 +0800
> Lai Jiangshan <jiangshanlai@gmail.com> wrote:
>
>> From: Lai Jiangshan <laijs@linux.alibaba.com>
>>
>> There is no any functionality change intended. Just rename it and
>> move it to arch/x86/kernel/nmi.c so that we can resue it later in
>> next patch for early NMI and kvm.
>
> Nit, but in change logs, please avoid stating "next patch" as searching git
> history (via git blame or whatever) there is no such thing as "next patch".
Interesting, I use next patch(es) relatively often, though you're right
that something like "in preparation for" works just as well. Yes, it's
the previous in "git log", but you get what it's meant in practice. :)
Paolo
> Just state: "so that we can reuse it for early NMI and KVM."
>
> I also just noticed the typo in "resue". Or maybe both NMI and KVM should
> be sued again ;-)
>
> -- Steve
>
next prev parent reply other threads:[~2021-04-30 7:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 23:09 [PATCH 0/4] x86: Don't invoke asm_exc_nmi() on the kernel stack Lai Jiangshan
2021-04-26 23:09 ` [PATCH 1/4] x86/xen/entry: Rename xenpv_exc_nmi to noist_exc_nmi Lai Jiangshan
2021-04-28 21:27 ` Steven Rostedt
2021-04-30 7:15 ` Paolo Bonzini [this message]
2021-04-30 12:05 ` Steven Rostedt
2021-05-03 19:05 ` Thomas Gleixner
2021-05-03 19:41 ` Thomas Gleixner
2021-05-10 7:59 ` Juergen Gross
2021-04-26 23:09 ` [PATCH 2/4] x86/entry: Use asm_noist_exc_nmi() for NMI in early booting stage Lai Jiangshan
2021-04-28 21:30 ` Steven Rostedt
2021-05-03 20:13 ` Thomas Gleixner
2021-05-03 20:24 ` Thomas Gleixner
2021-05-03 21:45 ` Thomas Gleixner
2021-05-04 12:43 ` Thomas Gleixner
2021-05-04 19:50 ` [PATCH] KVM/VMX: Invoke NMI non-IST entry instead of IST entry Thomas Gleixner
2021-05-04 21:05 ` Maxim Levitsky
2021-05-04 21:12 ` Paolo Bonzini
2021-05-04 21:21 ` Sean Christopherson
2021-05-04 21:23 ` Andy Lutomirski
2021-05-04 21:25 ` Paolo Bonzini
2021-05-04 21:51 ` Sean Christopherson
2021-05-04 21:56 ` Paolo Bonzini
2021-05-05 0:00 ` Thomas Gleixner
2021-05-05 15:44 ` Lai Jiangshan
2021-05-05 1:07 ` Lai Jiangshan
2021-05-05 1:11 ` Andy Lutomirski
2021-05-06 12:14 ` [tip: x86/urgent] " tip-bot2 for Lai Jiangshan
2021-04-26 23:09 ` [PATCH 3/4] " Lai Jiangshan
2021-04-30 2:46 ` Lai Jiangshan
2021-05-03 19:37 ` Thomas Gleixner
2021-05-03 20:02 ` Thomas Gleixner
2021-05-04 8:10 ` Paolo Bonzini
2021-04-26 23:09 ` [PATCH 4/4] KVM/VMX: Fold handle_interrupt_nmi_irqoff() into its solo caller Lai Jiangshan
2021-04-30 9:03 ` Thomas Gleixner
2021-04-30 9:06 ` Paolo Bonzini
2021-04-30 23:28 ` Thomas Gleixner
2021-04-30 7:14 ` [PATCH 0/4] x86: Don't invoke asm_exc_nmi() on the kernel stack Paolo Bonzini
2021-05-03 14:36 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77ee423-53fc-d552-1ff8-6fdf75e416a7@redhat.com \
--to=pbonzini@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexandre.chartre@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=caij2003@gmail.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jiangshanlai@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=laijs@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=ubizjak@gmail.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).