linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thara Gopinath <thara.gopinath@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>,
	mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rui.zhang@intel.com, qperret@google.com,
	daniel.lezcano@linaro.org, viresh.kumar@linaro.org,
	rostedt@goodmis.org, will@kernel.org, catalin.marinas@arm.com,
	sudeep.holla@arm.com, juri.lelli@redhat.com, corbet@lwn.net
Cc: linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
	javi.merino@kernel.org, amit.kucheria@verdurent.com
Subject: Re: [Patch v10 1/9] sched/pelt: Add support to track thermal pressure
Date: Sat, 22 Feb 2020 13:27:11 -0500	[thread overview]
Message-ID: <d7890dc4-f5d8-9bad-8473-062c0206da09@linaro.org> (raw)
In-Reply-To: <db1a554a-1c8a-0078-def5-4b5f1ee68c99@infradead.org>



On 2/21/20 7:59 PM, Randy Dunlap wrote:
> On 2/21/20 4:52 PM, Thara Gopinath wrote:
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 2a25c769eaaa..8d56902efa70 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -464,6 +464,10 @@ config HAVE_SCHED_AVG_IRQ
>>   	depends on IRQ_TIME_ACCOUNTING || PARAVIRT_TIME_ACCOUNTING
>>   	depends on SMP
>>   
>> +config HAVE_SCHED_THERMAL_PRESSURE
>> +	bool "Enable periodic averaging of thermal pressure"
> 
> This prompt string makes this symbol user-configurable, but
> I don't think that's what you want here.

Hi Randy,
Thank you for the review.
Actually I thought being user-configurable is a good idea as it will 
allow users to easily enable it and see if the benefits their systems. 
(I used menuconfig while developing, to enable it).
Do you see a reason why this should not be so?

> 
>> +	depends on SMP
>> +
>>   config BSD_PROCESS_ACCT
>>   	bool "BSD Process Accounting"
>>   	depends on MULTIUSER
> 
> 

-- 
Warm Regards
Thara

  reply	other threads:[~2020-02-22 18:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-22  0:52 [Patch v10 0/9] Introduce Thermal Pressure Thara Gopinath
2020-02-22  0:52 ` [Patch v10 1/9] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-02-22  0:59   ` Randy Dunlap
2020-02-22 18:27     ` Thara Gopinath [this message]
2020-02-22 18:50       ` Randy Dunlap
2020-02-24 14:33         ` Thara Gopinath
2020-02-25 15:47           ` Peter Zijlstra
2020-02-25 16:43             ` Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] " tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 2/9] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] sched/topology: Add callback to read per CPU " tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 3/9] drivers/base/arch_topology: Add infrastructure to store and update instantaneous " Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] " tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 4/9] arm64/topology: Populate arch_scale_thermal_pressure for arm64 platforms Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] arm64/topology: Populate arch_scale_thermal_pressure() " tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 5/9] arm/topology: Populate arch_scale_thermal_pressure for arm platforms Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] arm/topology: Populate arch_scale_thermal_pressure() for ARM platforms tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 6/9] sched/fair: Enable periodic update of average thermal pressure Thara Gopinath
2020-02-27  9:03   ` Amit Kucheria
2020-03-06 14:42   ` [tip: sched/core] " tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 7/9] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] sched/fair: Update " tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 8/9] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] " tip-bot2 for Thara Gopinath
2020-02-22  0:52 ` [Patch v10 9/9] sched/fair: Enable tuning of decay period Thara Gopinath
2020-03-06 14:42   ` [tip: sched/core] " tip-bot2 for Thara Gopinath
2020-02-27  9:01 ` [Patch v10 0/9] Introduce Thermal Pressure Amit Kucheria
     [not found] ` <CAP=VYLqWfqOZT6ec9cKyKOsOhu7HhVn2f_eU+ca006i4CV8R-w@mail.gmail.com>
2020-04-16 13:40   ` Thara Gopinath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7890dc4-f5d8-9bad-8473-062c0206da09@linaro.org \
    --to=thara.gopinath@linaro.org \
    --cc=amit.kachhap@gmail.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=javi.merino@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).