From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: mst@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next V2 3/3] tun: rx batching
Date: Fri, 30 Dec 2016 13:14:33 +0800 [thread overview]
Message-ID: <d7d1378d-2051-d962-8001-d63085c3e1bc@redhat.com> (raw)
In-Reply-To: <20161229.113506.1833529555874695164.davem@davemloft.net>
On 2016年12月30日 00:35, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Wed, 28 Dec 2016 16:09:31 +0800
>
>> + spin_lock(&queue->lock);
>> + qlen = skb_queue_len(queue);
>> + if (qlen > rx_batched)
>> + goto drop;
>> + __skb_queue_tail(queue, skb);
>> + if (!more || qlen + 1 > rx_batched) {
>> + __skb_queue_head_init(&process_queue);
>> + skb_queue_splice_tail_init(queue, &process_queue);
>> + rcv = true;
>> + }
>> + spin_unlock(&queue->lock);
> Since you always clear the 'queue' when you insert the skb that hits
> the limit, I don't see how the "goto drop" path can be possibly taken.
True, will fix this.
Thanks
next prev parent reply other threads:[~2016-12-30 5:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 8:09 [PATCH net-next V2 0/3] vhost net tx batching Jason Wang
2016-12-28 8:09 ` [PATCH net-next V2 1/3] vhost: better detection of available buffers Jason Wang
2017-01-03 13:08 ` Stefan Hajnoczi
2016-12-28 8:09 ` [PATCH net-next V2 2/3] vhost_net: tx batching Jason Wang
2017-01-03 13:16 ` Stefan Hajnoczi
2016-12-28 8:09 ` [PATCH net-next V2 3/3] tun: rx batching Jason Wang
2016-12-29 16:35 ` David Miller
2016-12-30 5:14 ` Jason Wang [this message]
2017-01-03 13:33 ` Stefan Hajnoczi
2017-01-04 3:03 ` Jason Wang
2017-01-05 9:27 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d1378d-2051-d962-8001-d63085c3e1bc@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).