From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC579C433B4 for ; Wed, 19 May 2021 11:19:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFD476135F for ; Wed, 19 May 2021 11:19:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350229AbhESLUW (ORCPT ); Wed, 19 May 2021 07:20:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42757 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349957AbhESLUK (ORCPT ); Wed, 19 May 2021 07:20:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621423130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NWPwTLXUbkkuBeNGwn+3y597gm6t7tmE54rpjMpE4pA=; b=RKWa2iA9rxg69RsfOxR9jwKscMv7Fhob28ukgfKT56LqXY+LuSIfkSuM7TyJgnF/l48eU9 gQ8jEjZQenGDyyaK0IkqOulyzt0ePcT38Edurz8qcswlmtKsyBS3OTBtICpxUG6BIgkNkK FnhPQaZ1KwVtz90da/4f05znrC04xCQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-DPauk6GuPn2fMnBLii4KJg-1; Wed, 19 May 2021 07:18:48 -0400 X-MC-Unique: DPauk6GuPn2fMnBLii4KJg-1 Received: by mail-wr1-f70.google.com with SMTP id 67-20020adf81490000b029010756d109e6so6958111wrm.13 for ; Wed, 19 May 2021 04:18:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NWPwTLXUbkkuBeNGwn+3y597gm6t7tmE54rpjMpE4pA=; b=STdH16SzVTJnnIZdL97afunnBI/ocA+z+z+QCqxI9MGCtleI72oYOEX/S9l/EVE6Bu iG24Qm3/lN1iC0aZdwgKsphR133onXqw5ElE1L2tbtbsuUy0QPZd3qcPvD/ZQzMPBNRy KmWpXWpg1eazrqVAWsX1hadwHLM4k09JGEEZKvQF3LUjwut7Up6g55WN2LOOQmg0hE/3 2Aiu+gIBZypdlftV788IL/gdmfvRX0timafaatEAbtm45g9/Olw5uox/p/+ZSL1IrAZY QJdm1c6CujxBWoSCCqkPZ3k5ZTWVY5/y9sE319K2FVL+BM7XpThgqU4y9b+4IySqkVJW W9hw== X-Gm-Message-State: AOAM530UsP0NQlBTE45f29z/EMBYTpKBilhURKY4mMpcG1vs3Ip6kn/H nPDumD8eyqEaBZzOnNEwYUlYfrmEOO6NfjfWCaUmmpivvtuuDnpkuPYdarBcnOVj+S6LhPwWnD6 4RvzCm55PES6Vy8WpN2pEyeb4 X-Received: by 2002:a5d:6910:: with SMTP id t16mr13720346wru.416.1621423127668; Wed, 19 May 2021 04:18:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsKGojU2DgZBTVi6QJ5uaGR/qngB2I/7EjHlNBsabqXVj4gNUE+e0fQBwiJa1DS8Rsi1PZLg== X-Received: by 2002:a5d:6910:: with SMTP id t16mr13720320wru.416.1621423127405; Wed, 19 May 2021 04:18:47 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id v10sm28926558wrq.0.2021.05.19.04.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 04:18:46 -0700 (PDT) To: Greg Kroah-Hartman , Anup Patel Cc: Anup Patel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Jonathan Corbet , Alexander Graf , Atish Patra , Alistair Francis , Damien Le Moal , KVM General , kvm-riscv@lists.infradead.org, linux-riscv , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org List" , linux-staging@lists.linux.dev References: <20210519033553.1110536-1-anup.patel@wdc.com> From: Paolo Bonzini Subject: Re: [PATCH v18 00/18] KVM RISC-V Support Message-ID: Date: Wed, 19 May 2021 13:18:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/21 12:47, Greg Kroah-Hartman wrote: >> It is not a dumping ground for stuff that arch maintainers can not seem >> to agree on, and it is not a place where you can just randomly play >> around with user/kernel apis with no consequences. >> >> So no, sorry, not going to take this code at all. > > And to be a bit more clear about this, having other subsystem > maintainers drop their unwanted code on this subsystem,_without_ even > asking me first is just not very nice. All of a sudden I am now > responsible for this stuff, without me even being asked about it. > Should I start throwing random drivers into the kvm subsystem for them > to maintain because I don't want to?:) (I did see the smiley), I'm on board with throwing random drivers in arch/riscv. :) The situation here didn't seem very far from what process/2.Process.rst says about staging: - "a way to keep track of drivers that aren't up to standards", though in this case the issue is not coding standards or quality---the code is very good---and which people "may want to use" - the code could be removed if there's no progress on either changing the RISC-V acceptance policy or ratifying the spec Of course there should have been a TODO file explaining the situation. But if you think this is not the right place, I totally understand; if my opinion had any weight in this, I would just place it in arch/riscv/kvm. The RISC-V acceptance policy as is just doesn't work, and the fact that people are trying to work around it is proving it. There are many ways to improve it: - get rid of it; - provide a path to get an exception; - provide a staging place sot hat people to do their job of contributing code to Linux (e.g. arch/riscv/staging/kvm). If everything else fail, I guess we can place it in drivers/virt/riscv/kvm, even though that's just as silly a workaround. It's a pity because the RISC-V virtualization architecture has a very nice design, and the KVM code is also a very good example of how to do things right. Paolo > If there's really no other way to do this, than to put it in staging, > let's talk about it. But saying "this must go here" is not a > conversation...